O2DPG-MC: Possibility to pass additional external user settings #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides the possibility to inject external choices
for configurable params into the MC workflow construction.
This is done by setting up a JSON file, e.g. local_config.json,
an by passing this file to the workflow construction with the new
`--overwrite-config local_config.json` command line option.
This new option allows to conveniently set configurable params
from the outside (without having to specify the global list of configurations).
The motivation for this development came from the wish to set the busy
time for EMC digitization. This is now possible with the following local_config.json:
```
{
"EMCSimParam": {
"mBusyTime": 0
}
}
```
Overall, this development scales to all such external settings and avoids adding
specific detector-specific command line options in o2dpg_sim_workflow.py.
sawenzel
requested review from
chiarazampolli and
benedikt-voelkel
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
alcaliva
added
async-2022-pp-apass7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides the possibility to inject external choices for configurable params into the MC workflow construction.
This is done by setting up a JSON file, e.g. local_config.json, an by passing this file to the workflow construction with the new
--overwrite-config local_config.jsoncommand line option.This new option allows to conveniently set configurable params from the outside (without having to specify the global list of configurations).
The motivation for this development came from the wish to set the busy time for EMC digitization. This is now possible with the following local_config.json:
Overall, this development scales to all such external settings and avoids adding specific detector-specific command line options in o2dpg_sim_workflow.py.