Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1365] Disable GAQ for not fully covered runs #1784

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Oct 14, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • GAQ summary is not displayed when not all runs are fully covered by QC flags
  • GAQ overview shows not covered periods

Notable changes for developers:

  • Added QC flags seeders to cover corner cases of QC/GAQ summaries displays
  • Reworked QC flag Types seeders to make them more meaningful

Changes made to the database:

  • NA

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.81%. Comparing base (ac219f9) to head (6b3aee3).

Files with missing lines Patch % Lines
...ews/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js 0.00% 4 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
+ Coverage   43.77%   43.81%   +0.04%     
==========================================
  Files         893      893              
  Lines       15956    15974      +18     
  Branches     3003     3010       +7     
==========================================
+ Hits         6984     6999      +15     
- Misses       8972     8975       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@xsalonx xsalonx changed the title [O2B-1365] Disable GAQ summary if not all detectors have full coverage [O2B-1365] Disable GAQ for not fully covered runs Nov 21, 2024
@xsalonx xsalonx marked this pull request as ready for review November 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant