Printing log when we find a default CCDB entry #8659
Conversation
|
@chiarazampolli the place is correct, but I would not consider different cases, just |
|
Ok, I can remove the various options for writing "default", but what if someone used "default = false" to specify that it is not a default? I would keep the check on the value. |
|
Who can use it? The default objects should be uploaded manually and this can be done by special operators only. If we can avoid passing the value at all, I would prefer this. |
|
Ok, I will change it. |
|
Done. |
chiarazampolli
force-pushed
the
printDefCCDB
branch
from
930c7b7 to
0f001d6
Compare
Framework/Core/src/CCDBHelpers.cxx
Outdated
| @@ -211,6 +212,10 @@ auto populateCacheWith(std::shared_ptr<CCDBFetcherHelper> const& helper, | |||
| // FIXME: I should send a dummy message. | |||
| continue; | |||
| } | |||
| // printing in case we find a default entry | |||
| if (headers.find("default") != headers.end()) { | |||
| LOGP(info, "******** Default entry used for {} ********", path); | |||
There was a problem hiding this comment.
| LOGP(info, "******** Default entry used for {} ********", path); | |
| LOGP(detail, "******** Default entry used for {} ********", path); |
There was a problem hiding this comment.
What is the effect of "detail"?
There was a problem hiding this comment.
It's like info, but it does not go to infologger.
Framework/Core/src/CCDBHelpers.cxx
Outdated
| @@ -23,6 +23,7 @@ | |||
| #include <TError.h> | |||
| #include <TMemFile.h> | |||
| #include <functional> | |||
| #include <boost/algorithm/string/predicate.hpp> | |||
There was a problem hiding this comment.
It is indeed not needed anymore, after the changes following Ruben's comments, I will remove it. Thanks for spotting.
chiarazampolli
force-pushed
the
printDefCCDB
branch
from
0f001d6 to
ef1b0fc
Compare
|
@chiarazampolli I've checked, the metadata with empty value does not work, so we have to provide something but should look on the presence of the tag only. |
|
Ciao, Yes, I had not understood that you proposed to not add the value at all. We should just make sure that the value is not misleading when we do the manual upload. |
|
If there are no more comments, can this be approved? |
@shahor02 , @ktf , is this the correct place? From a local test it works, but I don't know if it covers all possibilities.
I would allow the three keys "default", "Default", "DEFAULT", let me know what you think.