Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for subjob spawning with FIFOs #13824

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

jackal1-66
Copy link
Collaborator

@jackal1-66 jackal1-66 commented Dec 19, 2024

When running jobs spawning with GeneratorFileOrCmd it could happen that the subjob is still running after the FIFO has been deleted by the destructor. This was not a problem before the destructors Fix, but it is now, especially in situations in which the number of events to be generated by the subgenerator exceeds the actual needed number for the o2-sim generation (such as hyperloop configurations). This fix implements a different spawning mechanism using fork() and allows the destructor to kill the subjobs via their PIDs.

@jackal1-66 jackal1-66 requested a review from sawenzel as a code owner December 19, 2024 18:03
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 18899fe at 2024-12-20 03:56:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13824-slc8_x86-64/0/Generators/src/GeneratorFileOrCmd.cxx:20:10: error: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@sawenzel sawenzel merged commit 8662a04 into AliceO2Group:dev Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants