Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS: Improved memory usage for vresetd scan #13823

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

iravasen
Copy link
Contributor

Before: thresholds for each VRESETD extracted only at the END of the scan
Now: thresholds extracted every time the VRESETD changes, then memory is erased

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@mconcas
Copy link
Collaborator

mconcas commented Dec 20, 2024

@iravasen is this good to go?

@iravasen iravasen marked this pull request as draft December 20, 2024 09:57
@iravasen
Copy link
Contributor Author

@iravasen is this good to go?

Hi @mconcas, I found some problems with this code and I'm testing further. Moved to draft for now.

@iravasen iravasen marked this pull request as ready for review December 20, 2024 17:18
@iravasen
Copy link
Contributor Author

@mconcas now ready.

@mconcas mconcas merged commit 5b004eb into AliceO2Group:dev Dec 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants