Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL Analysis: drop aod-file-private #13671

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

DPL Analysis: drop aod-file-private #13671

wants to merge 4 commits into from

Conversation

ktf
Copy link
Member

@ktf ktf commented Nov 8, 2024

This was a hack introduced to pass a workflow option to an AlgorithmSpec created
by a plugin. Not needed anymore now that we properly pass the ConfigContext to plugins
as well.

Stack created with Sapling. Best reviewed with ReviewStack.

ktf added 2 commits November 8, 2024 11:51
In the case of self contained derived data, it is ok not to look in the parents
for missing metadata.
This was a hack introduced to pass a workflow option to an AlgorithmSpec created
by a plugin. Not needed anymore now that we properly pass the ConfigContext to plugins
as well.
@ktf ktf requested a review from a team as a code owner November 8, 2024 10:52
Copy link
Contributor

github-actions bot commented Nov 8, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant