Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC/simulation: Add PT correction to gas density using configurable p… #13048

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

tubagundem
Copy link
Contributor

@tubagundem tubagundem commented Apr 19, 2024

Added pressure and temperature correction to gas density in simulation (copied from AliRoot).

The default parameters are in Detectors/TPC/base/include/TPCBase/ParameterGas.h. The default value for the PT correction is 1. To enable the correction, add
--configKeyValues "TPCGasParam.Pressure=yourValue;TPCGasParam.Temperature=yourValue" to o2-sim workflow.

Loading the pressure and temperature values from CCDB will be added in the future.

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just a few minor suggestions.

Detectors/TPC/base/include/TPCBase/ParameterGas.h Outdated Show resolved Hide resolved
Detectors/TPC/simulation/src/Detector.cxx Outdated Show resolved Hide resolved
Detectors/TPC/simulation/src/Detector.cxx Outdated Show resolved Hide resolved
@wiechula wiechula marked this pull request as ready for review April 22, 2024 07:21
@wiechula wiechula merged commit 8a36206 into AliceO2Group:dev Apr 23, 2024
13 checks passed
@tubagundem tubagundem deleted the TPC_MC branch April 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants