-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 8.3 and Swift 3.x support #240
Conversation
I think by now it would be better to have the following branch setup:
Because if today we make Thoughts? |
Yeah probably 👍 (Just to be clear, we won't need a build matrix to always build master on all Xcode's, just each branch — |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a badge on top of the README (next to all the other badges) to indicate the Swift version we support, so users won't be lost
[![Language: Swift 3.1](https://img.shields.io/badge/Swift-3.1-orange.svg)](https://swift.org)
(We could retroactively add this badge to each swift-x.y
branch as well)
Is there really a difference between Swift 3.1 and Swift 3.0? |
I don't think there is any code change needed at all. |
Side note: we need to migrate OHHTTPStubs to Circle-CI some day… travis is still taking forever :'( |
@@ -328,6 +333,7 @@ | |||
IPHONEOS_DEPLOYMENT_TARGET = 8.3; | |||
MTL_ENABLE_DEBUG_INFO = NO; | |||
SDKROOT = iphoneos; | |||
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; | |||
SWIFT_VERSION = 2.3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this line still 2.3? (I'm reading that from the GitHub web page on mobile, so hard to easily get the context of that line in the whole xcodeproj to check if it's normal, but seems strange to me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the project level settings which is overwritten by the target level settings. I'll change that and remove the target level one.
@Liquidsoul Now that this is merged:
Next steps is to:
|
@AliSoftware I've just pushed the badge in branch |
👌 |
I noticed that the releases are versioned as:
Moving forward, will this be switched to?
|
Yep exactly that's what I plan indeed. Do you think we should do otherwise? Suggestions welcome. Also wondering if I should bump the next release to 6.0.0 because the switch from 2.3 to 3.0 is source-breaking (I think, will have to compare our APIs for the two versions to check if the call site has to be changed or not 🤔)… |
I agree you should make 5.2.3 not compatible with the next version since they are not compatible, so 👍 on 6.0.0 |
This pull request is mostly a merge of the
swift-3.0
branch to implement #233 :master
use Swift 3.0 as default.Once this is merged we will create a
swift-2.3
branch to allow users to use the legacy Swift version if they need it.❓
One thing I am wondering is if the Travis CI configuration should not be updated in this PR to test both Xcode 8.3 and Xcode 8.2?🙄Maybe at least change the
osx_image
toxcode8.3
instead ofxcode8
which from travis' documentation targets some Xcode 8 GMThe build matrix has been updated to use Xcode 8.3.
A language badge has been added to the
README
file.