Migrate samples to Swift 3 #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👌 Could you also add an entry in the CHANGELOG to credit yourself for this migration? Thx! |
|
Sure, updated. Hope the format is ok above the previous release? Let me know if not and I'll fix. |
AliSoftware
requested changes
Sep 21, 2016
| @@ -1,5 +1,8 @@ | |||
| # OHHTTPStubs — CHANGELOG | |||
|
|
|||
| * Migrate samples to Swift 3 | |||
There was a problem hiding this comment.
Could you add a full stop and 2 spaces at the end of that line so that the markdown formatting matches the other notes?
AliSoftware
approved these changes
Oct 4, 2016
|
Travis-CI builds are currently failing due to a bug in the latest version of |
AliSoftware
force-pushed
the
swift-3.0
branch
2 times, most recently
from
1b93a24 to
ca8e9c2
Compare
|
Merged manually via ca8e9c295b859215b1ab8a9df8e0546a24e768e5 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carthage seems to find this example project and fall over when the dependencies are checked using Xcode 8 as it’s not specifying the swift version. This appears to fix that. It does seem to build the framework target twice due to the cocoa pods usage for the example, but I don’t think that causes a problem. Perhaps in future the example project could link directly to the project rather than using CocoaPods to solve that, but probably not urgent.