Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tvos support for 'Swift' subspec #136

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Adding tvos support for 'Swift' subspec #136

merged 1 commit into from
Nov 3, 2015

Conversation

pavelpantus
Copy link
Contributor

No description provided.

@AliSoftware
Copy link
Owner

Ah! Isn't it inherited from the parent specification?

If so we'll probably need to re-specify it for watchOS too then.

@AliSoftware
Copy link
Owner

Could you add the watchOS platform to the Swift subspec too, and add a ## Master entry in the CHANGELOG for that change to credit yourself?

Thanks

@AliSoftware AliSoftware merged commit 9c4c0be into AliSoftware:master Nov 3, 2015
@pavelpantus
Copy link
Contributor Author

Hi, thanks for merging. Will definitely add watchOS platform when have a minute.

@AliSoftware
Copy link
Owner

Don't bother: I finally did it myself along with the CHANGELOG 😉

AliSoftware added a commit that referenced this pull request Nov 3, 2015
@AliSoftware
Merge PR #136
eb6d843
@AliSoftware
Copy link
Owner

4.5.1 released to CocoaPods! Thx again for the PR

@pavelpantus
Copy link
Contributor Author

That's fast! Thank you! Time to update my Podfile ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelpantus @AliSoftware