Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental/tv os support #134

Merged
merged 6 commits into from
Oct 31, 2015
Merged

Experimental/tv os support #134

merged 6 commits into from
Oct 31, 2015

Conversation

tiagomartinho
Copy link
Contributor

Hello!

I created the branch to support tvOS.

It uses the pod AFNetworking 3.0.0 (beta 1) since they added support to tvOS.

I only added the target for building a Framework and didn't add the target for a static library.

I had to bump the deployment target of iOS to 7.0 and OS X to 10.9 because of AFNetworking 3.

Two tests don't pass (and I don't understand their usefulness) since the method setRedirectResponseBlock is no longer defined in AFNetworking.

tiagomartinho added 3 commits October 28, 2015 19:52
…ation_success tests, AFHTTPRequestOperation_multiple_choices and AFHTTPRequestOperation_redirect fail since setRedirectResponseBlock method is no longer defined in AFNetworking
@AliSoftware
Copy link
Owner

Thanks for the PR ! 🍎 📺

Sadly I won't have much time those days to fully review it but I hope to look at it in detail this week-end.

I'm not sure I understood why you had to bump the minimum deployment targets of the pod for iOS and OS X, since the pod doesn't have a dependency on AFNetworking, only the test targets do.
So theoretically you should only had to bump the Deployment Target build setting of the Unit Tests target, not the podspec which doesn't depend on AFN, right?

Regarding the tests about the redirect block was to ensure the redirections were properly followed by OHHTTPStubs and especially that there weren't any regression on this part of the code logic. So I think we should still keep those tests, but they probably need to be adapted/rewritten to make a redirection using whatever new method AFNetworking 3 provides for that.

@tiagomartinho
Copy link
Contributor Author

You were right, the deployment version should only be increased by the tests targets. I reverted the deployment target for the pod targets.

Regarding the tests I found that AFNetworking has the method setTaskWillPerformHTTPRedirectionBlock in AFURLSessionManager. I will try using this one to adapt the failing tests.

tiagomartinho added 2 commits October 29, 2015 11:09
…kWillPerformHTTPRedirectionBlock method from AFNetworking 3.0
…formHTTPRedirectionBlock method from AFNetworking 3.0
@tiagomartinho
Copy link
Contributor Author

I was able to fix the failing tests using the setTaskWillPerformHTTPRedirectionBlock method from AFNetworking.

@AliSoftware
Copy link
Owner

Great! Will take a look probably this weekend. Thanks a lot!

@AliSoftware AliSoftware merged commit b1c9f49 into AliSoftware:master Oct 31, 2015
@AliSoftware
Copy link
Owner

4.5.0 is out, thanks a lot for this PR again!

@tiagomartinho
Copy link
Contributor Author

Welcome! Thank you for merging.

Sent from my iPad

On 31 Oct 2015, at 22:16, AliSoftware [email protected] wrote:

4.5.0 is out, thanks a lot for this PR again!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants