-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental/tv os support #134
Experimental/tv os support #134
Conversation
…ation_success tests, AFHTTPRequestOperation_multiple_choices and AFHTTPRequestOperation_redirect fail since setRedirectResponseBlock method is no longer defined in AFNetworking
… target to 10.7, add tvos target
Thanks for the PR ! 🍎 📺 Sadly I won't have much time those days to fully review it but I hope to look at it in detail this week-end. I'm not sure I understood why you had to bump the minimum deployment targets of the pod for iOS and OS X, since the pod doesn't have a dependency on AFNetworking, only the test targets do. Regarding the tests about the redirect block was to ensure the redirections were properly followed by |
You were right, the deployment version should only be increased by the tests targets. I reverted the deployment target for the pod targets. Regarding the tests I found that AFNetworking has the method setTaskWillPerformHTTPRedirectionBlock in AFURLSessionManager. I will try using this one to adapt the failing tests. |
…kWillPerformHTTPRedirectionBlock method from AFNetworking 3.0
…formHTTPRedirectionBlock method from AFNetworking 3.0
I was able to fix the failing tests using the setTaskWillPerformHTTPRedirectionBlock method from AFNetworking. |
Great! Will take a look probably this weekend. Thanks a lot! |
4.5.0 is out, thanks a lot for this PR again! |
Welcome! Thank you for merging. Sent from my iPad
|
Hello!
I created the branch to support tvOS.
It uses the pod AFNetworking 3.0.0 (beta 1) since they added support to tvOS.
I only added the target for building a Framework and didn't add the target for a static library.
I had to bump the deployment target of iOS to 7.0 and OS X to 10.9 because of AFNetworking 3.
Two tests don't pass (and I don't understand their usefulness) since the method setRedirectResponseBlock is no longer defined in AFNetworking.