Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tran/counter page #10

Merged
merged 6 commits into from
Jan 4, 2025
Merged

Tran/counter page #10

merged 6 commits into from
Jan 4, 2025

Conversation

Tranimal-N
Copy link
Contributor

@Tranimal-N Tranimal-N commented Dec 11, 2024 •
edited
Loading

Overview

task-name
Tran/counter page

  • Bug
  • Feature
  • Tech Debt

Description
Built counter page frontend

Ticket Item

Steps to Reproduce Bug / Validate Feature / Confirm Tech Debt Fix

  1. Enter name and email
  2. Either hit "return" or "Signup" button to signup and enter PII into database
  3. Both fields should be required
  4. count should increase with each signup
  5. count should perpetuate when page reloads

Additional context

  • Created form fields for name and email with labels for accessibility
  • Upgraded to React 19 and refactored code to use new form functionalities
  • I still need to build out Figma and Sass mini libraries and tighten up styling

@KP824 KP824 added the enhancement New feature or request label Dec 12, 2024
@KP824
Copy link
Contributor

KP824 commented Dec 12, 2024

Looks good. Is there a ticket to go with this PR? I think you can update the ticket it into an issue and assign it from the "Development" tab on the right.

@Tranimal-N Tranimal-N self-assigned this Dec 13, 2024
@Tranimal-N Tranimal-N linked an issue Dec 13, 2024 that may be closed by this pull request
Build out counter page #11
Closed
KP824
KP824 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@KP824 KP824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Tran!

@KP824 KP824 merged commit 7284fa3 into dev Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KP824 KP824 KP824 approved these changes

@victorhe33 victorhe33 victorhe33 approved these changes

Assignees

@Tranimal-N Tranimal-N

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build out counter page
3 participants
@Tranimal-N @KP824 @victorhe33