Fix empty collection typing bug #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing for an unrelated reason (#942). Let's hold off for the moment and try to fix that. |
epatters
force-pushed
the
fixIsolatedAttrtypeBug
branch
from
7646fd2
to
6238d81
Compare
epatters
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3f95da1 introduced a regression for constructing Yoneda in the case of a schema that has an
AttrTypeswith noAttrspointing to it, which surprisingly enough is sometimes useful (in case you want to migrate from a schema withAttrTypesto one without for migrations including code.) The problem was thatunionhas no method for empty input since it can't decide on the output type, because typing Julia collections in empty cases is our entire job here. I fixed it.