Windows compat for nauty #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 88.82% 89.24% +0.41%
==========================================
Files 22 25 +3
Lines 1960 2092 +132
==========================================
+ Hits 1741 1867 +126
- Misses 219 225 +6 ☔ View full report in Codecov by Sentry. |
kris-brown
force-pushed
the
windows_compat
branch
from
e9349af
to
b9b0451
Compare
added 2 commits
March 7, 2024 17:06
The code wasn't being hit in the test cases
|
I've tested AlgebraicJulia/Catlab.jl#893 with this branch and it works both with the external call to |
|
I'll take a path of lower resistance for the time being, though fixing this up would be nice to return to in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catlab is committed to having Windows support, so for
nautyto be used there we need to have it supported in ACSets.jl. This could be done by a relatively-naive reimplementation ofnautywithin Julia (used only if one is on Windows), which is adapted from some big chunks of https://github.com/AlgebraicJulia/CSetAutomorphisms.jl.Much like the nauty interface code, it is not pretty (though there is a path to making the other code better: #52). Given that its only reason for existence is to allow our tests to pass on Windows, this might be acceptable.
Documentation of what's going on in the code at a high level in this blog post