Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-3938] support for XMLHttpRequest.withCredentials flag #4190

Merged
merged 5 commits into from
Jan 25, 2019

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jan 21, 2019

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • provide support for XMLHttpRequest.withCredentials (corresponding flag has been previously contributed to JS-API by the community)
  • global (app config) setting to enable both PDF Viewer and JS-API flags

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

refs Alfresco/alfresco-content-app#894

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/ADF-3938

@DenysVuika DenysVuika requested a review from eromano January 21, 2019 18:55
@DenysVuika DenysVuika changed the title support for XMLHttpRequest.withCredentials flag [ADF-3938] support for XMLHttpRequest.withCredentials flag Jan 21, 2019
@eromano
Copy link
Contributor

eromano commented Jan 23, 2019

./demo-shell/src/app.config.json invalid
data.baseShareUrl should be string

@DenysVuika
Copy link
Contributor Author

@eromano I removed baseShareUrl from the app.config as it makes no sense setting it to null there.

@DenysVuika DenysVuika force-pushed the denys-auth-with-credentials branch from f3c873d to 3cd55c7 Compare January 23, 2019 19:34
@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4190 into development will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4190      +/-   ##
===============================================
+ Coverage        82.67%   83.12%   +0.45%     
===============================================
  Files              677      298     -379     
  Lines            19341     9863    -9478     
  Branches          2855     1439    -1416     
===============================================
- Hits             15990     8199    -7791     
+ Misses            2486     1235    -1251     
+ Partials           865      429     -436
Impacted Files Coverage Δ
lib/core/services/people-process.service.ts
lib/core/services/jwt-helper.service.ts
lib/core/buttons-menu/buttons-menu.module.ts
...-view-selectitem/card-view-selectitem.component.ts
lib/core/info-drawer/index.ts
lib/core/datatable/data/data-row-event.model.ts
lib/core/buttons-menu/buttons-menu.component.ts
lib/core/directives/index.ts
lib/core/language-menu/index.ts
lib/core/pipes/time-ago.pipe.ts
... and 366 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34ff07...61892db. Read the comment docs.

@DenysVuika DenysVuika force-pushed the denys-auth-with-credentials branch from 3cd55c7 to fb0a908 Compare January 24, 2019 10:38
@eromano eromano merged commit 5887fa1 into development Jan 25, 2019
@eromano eromano added this to the 3.0.0 milestone Jan 25, 2019
@eromano eromano deleted the denys-auth-with-credentials branch February 22, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants