Aae 23572 recreate js api lib into a proper nx workspace lib bis (#9917)

* back to mocha, working in future node versions * update package-lock * change bundle to build * update node to 18.20.3 [ci:force] * fix e2es [ci:force] * bring bundle back to fix e2e [ci:force] * patch in legacy builds * Updated package-lock * Updated executor to new @nx * Revert "Updated executor to new @nx" This reverts commit a520ba3. * Improved ts config reverted changes on @nrwl --------- Co-authored-by: Wojciech Duda <[email protected]>
Alfresco · Jul 5, 2024 · 9d72d68 · 9d72d68
1 parent 764633e
commit 9d72d68
Show file tree

Hide file tree

Showing 10 changed files with 4,536 additions and 10,497 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18.18.2
+18.20.3
diff --git a/lib/js-api/.mocharc.json b/lib/js-api/.mocharc.json
@@ -1,7 +1,4 @@
 {
   "extensions": ["ts"],
-  "spec": ["lib/js-api/test/**/*.spec.ts"],
-  "node-option": [
-    "loader=ts-node/register"
-  ]
+  "spec": ["dist/tmp/libs/js-api/test/**/*.spec.js"]
 }
diff --git a/lib/js-api/project.json b/lib/js-api/project.json
@@ -0,0 +1,106 @@
+{
+  "name": "js-api",
+  "$schema": "../../node_modules/nx/schemas/project-schema.json",
+  "sourceRoot": "lib/js-api",
+  "projectType": "library",
+  "prefix": "adf",
+  "targets": {
+    "build": {
+      "executor": "@nrwl/js:tsc",
+      "outputs": ["{options.outputPath}"],
+      "options": {
+        "outputPath": "dist/libs/js-api",
+        "main": "lib/js-api/src/index.ts",
+        "tsConfig": "lib/js-api/tsconfig.lib.json",
+        "assets": ["lib/js-api/*.md"],
+        "externalBuildTargets": [
+          "build"
+        ]
+      },
+      "configurations": {
+        "test": {
+          "outputPath": "dist/tmp/libs/js-api",
+          "tsConfig": "lib/js-api/tsconfig.spec.json",
+          "assets": [
+            "lib/js-api/test/mockObjects/assets/**/*"
+          ]
+        }
+      }
+    },
+    "build-all": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          "npm run js_api_build"
+        ]
+      }
+    },
+    "publish": {
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "node tools/scripts/publish.mjs lib-js-api {args.ver} {args.tag}"
+      },
+      "dependsOn": [
+        {
+          "projects": "self",
+          "target": "build-all"
+        }
+      ]
+    },
+    "lint": {
+      "executor": "@nrwl/linter:eslint",
+      "outputs": ["{options.outputFile}"],
+      "options": {
+        "lintFilePatterns": ["lib/js-api/**/*.ts"]
+      }
+    },
+    "bundle": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          {
+            "command": "echo cli bundle created"
+          }
+        ]
+      },
+      "dependsOn": [
+        "copyToNodeModules"
+      ]
+    },
+    "copyToNodeModules": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          {
+            "command": "rm -rf ./node_modules/@alfresco/js-api/ && mkdir -p ./node_modules/@alfresco/js-api/ && cp -R ./dist/libs/js-api/* ./node_modules/@alfresco/js-api/"
+          }
+        ]
+      },
+      "dependsOn": [
+        {
+          "projects": "self",
+          "target": "build-all"
+        }
+      ]
+    },
+    "test": {
+      "executor": "nx:run-commands",
+      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
+      "options": {
+        "commands": [
+          "nx run js-api:build:test",
+          "mocha --full-trace --config lib/js-api/.mocharc.json",
+          "rm -fr dist/tmp/libs/js-api"
+        ],
+        "parallel": false
+      },
+      "configurations": {
+        "ci": {
+          "ci": true,
+          "codeCoverage": true
+        }
+      }
+    }
+  },
+  "tags": []
+}
diff --git a/lib/js-api/test/oauth2AuthImplicitFlow.spec.ts b/lib/js-api/test/oauth2AuthImplicitFlow.spec.ts
@@ -53,7 +53,13 @@ describe('Oauth2 Implicit flow test', () => {
     });
 
     it('should redirect to login if access token is not valid', (done) => {
-        window = globalAny.window = { location: {} };
+        window = globalAny.window = {
+            location: {
+                assign: (v: any) => {
+                    window.location.href = v;
+                }
+            }
+        };
         globalAny.document = {
             getElementById: () => ''
         };
@@ -81,7 +87,13 @@ describe('Oauth2 Implicit flow test', () => {
     });
 
     it('should not loop over redirection when redirectUri contains hash and token is not valid ', (done) => {
-        window = globalAny.window = { location: {} };
+        window = globalAny.window = {
+            location: {
+                assign: (v: any) => {
+                    window.location.href = v;
+                }
+            }
+        };
         globalAny.document = {
             getElementById: () => ''
         };
@@ -112,7 +124,13 @@ describe('Oauth2 Implicit flow test', () => {
     });
 
     it('should not redirect to login if access token is valid', (done) => {
-        window = globalAny.window = { location: {} };
+        window = globalAny.window = {
+            location: {
+                assign: (v: any) => {
+                    window.location.href = v;
+                }
+            }
+        };
         globalAny.document = {
             getElementById: () => ''
         };
@@ -144,11 +162,17 @@ describe('Oauth2 Implicit flow test', () => {
     });
 
     it('should set the loginFragment to redirect after the login if it is present', (done) => {
-        window = globalAny.window = {};
+        window = globalAny.window = {
+            location: {
+                assign: (v: any) => {
+                    window.location.href = v;
+                }
+            }
+        };
         globalAny.document = {
             getElementById: () => ''
         };
-        window.location = <Location>{ hash: 'asfasfasfa' };
+        window.location.hash = 'asfasfasfa';
 
         Object.defineProperty(window.location, 'hash', {
             writable: true,

diff --git a/lib/js-api/test/tsconfig.json b/lib/js-api/test/tsconfig.json
@@ -7,8 +7,6 @@
     "esModuleInterop": true,
     "isolatedModules": true,
     "allowSyntheticDefaultImports": true,
-    "skipLibCheck": true,
-    "skipDefaultLibCheck": true,
-    "types": ["mocha"]
+    "lib": ["ESNext", "dom"]
   }
 }
diff --git a/lib/js-api/tsconfig.spec.json b/lib/js-api/tsconfig.spec.json
@@ -0,0 +1,15 @@
+{
+  "extends": "../../tsconfig.json",
+  "compilerOptions": {
+    "module": "CommonJS",
+    "moduleResolution": "node",
+    "target": "ES2015",
+    "esModuleInterop": true,
+    "isolatedModules": true,
+    "allowSyntheticDefaultImports": true,
+    "lib": ["ESNext", "dom"],
+    "types": ["mocha"]
+  },
+  "exclude": [],
+  "include": ["**/*"]
+}
diff --git a/lib/process-services-cloud/.nvmrc b/lib/process-services-cloud/.nvmrc
@@ -1 +1 @@
-18.18.2
+18.20.3