-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPSEXP-1257 make sure alpine base is updated #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace with 3.15.0 without sha256 that seems incorrect, semver is enough, no need to update packages
hash is correct:
reason for why digest on dockhub is different than digest pulling images: the combination of minor version + sha is the best approach to get controlled updates from dependabot:
|
this is fine, dependabot can create the PR when there is semver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change
@@ -70,7 +70,9 @@ ENV JAVA_HOME=/usr/lib/jvm/java-${JAVA_MAJOR}-openjdk | |||
ENV LANG C.UTF-8 | |||
ENV LC_ALL C.UTF-8 | |||
|
|||
RUN apk add openjdk${JAVA_MAJOR}-${JDIST}-headless | |||
RUN apk update && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use the short form apk -U upgrade
and add --no-cache
to all commands or add rm -vrf /var/cache/apk/*
after to save a few MB of package index - see: https://newbedev.com/alpine-dockerfile-advantages-of-no-cache-vs-rm-var-cache-apk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing that will download index two times (one for the upgrade and again for the apk add), it's better to delete index at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OPSEXP-1257
image on dockerhub is not updated on regular basis, e.g.: