Alfresco · suzanadirla · Jan 29, 2019 · Jan 23, 2019 · Jan 23, 2019 · Jan 23, 2019
diff --git a/e2e/suites/actions/context-menu-multiple-selection.test.ts b/e2e/suites/actions/context-menu-multiple-selection.test.ts
@@ -98,8 +98,6 @@ describe('Context menu actions - multiple selection : ', () => {
     done();
   });
 
-  xit('');
-
   describe('Generic tests', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();

diff --git a/e2e/suites/actions/context-menu-single-selection.test.ts b/e2e/suites/actions/context-menu-single-selection.test.ts
@@ -102,8 +102,6 @@ describe('Context menu actions - single selection : ', () => {
     done();
   });
 
-  xit('');
-
   describe('Generic tests', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();

diff --git a/e2e/suites/actions/copy.test.ts b/e2e/suites/actions/copy.test.ts
@@ -555,6 +555,4 @@ describe('Copy', () => {
     });
   });
 
-  xit('');
-
 });
diff --git a/e2e/suites/actions/create-folder.test.ts b/e2e/suites/actions/create-folder.test.ts
@@ -263,5 +263,4 @@ describe('Create folder', () => {
     });
   });
 
-  xit('');
 });
diff --git a/e2e/suites/actions/delete-undo-delete.test.ts b/e2e/suites/actions/delete-undo-delete.test.ts
@@ -49,8 +49,6 @@ describe('Delete and undo delete', () => {
     done();
   });
 
-  xit('');
-
   describe('on Personal Files', () => {
     const file1 = `file1-${Utils.random()}.txt`;
     const file2 = `file2-${Utils.random()}.txt`;

diff --git a/e2e/suites/actions/mark-favorite.test.ts b/e2e/suites/actions/mark-favorite.test.ts
@@ -89,8 +89,6 @@ describe('Mark items as favorites', () => {
     done();
   });
 
-  xit('');
-
   describe('on Personal Files', () => {
     afterAll(async (done) => {
       await apis.user.favorites.addFavoritesByIds('file', [ fileFavUIId, fileFav1Id, fileFav2Id, fileFav3Id, fileFav4Id ]);

diff --git a/e2e/suites/actions/restore.test.ts b/e2e/suites/actions/restore.test.ts
@@ -52,8 +52,6 @@ describe('Restore from Trash', () => {
     done();
   });
 
-  xit('');
-
   describe('successful restore', () => {
     const file = `file-${Utils.random()}.txt`; let fileId;
     const folder = `folder-${Utils.random()}`; let folderId;

diff --git a/e2e/suites/actions/share-file.test.ts b/e2e/suites/actions/share-file.test.ts
@@ -1011,6 +1011,4 @@ describe('Share a file', () => {
     });
   });
 
-  xit('');
-
 });
diff --git a/e2e/suites/actions/special-permissions-available-actions.test.ts b/e2e/suites/actions/special-permissions-available-actions.test.ts
@@ -103,8 +103,6 @@ describe('Granular permissions available actions : ', () => {
     done();
   });
 
-  xit('');
-
   describe('toolbar displays correct actions when selecting multiple files with different granular permissions', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();

diff --git a/e2e/suites/actions/toolbar-multiple-selection.test.ts b/e2e/suites/actions/toolbar-multiple-selection.test.ts
@@ -111,8 +111,6 @@ describe('Toolbar actions - multiple selection : ', () => {
     done();
   });
 
-  xit('');
-
   describe('on Personal Files', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();

diff --git a/e2e/suites/actions/toolbar-single-selection.test.ts b/e2e/suites/actions/toolbar-single-selection.test.ts
@@ -101,8 +101,6 @@ describe('Toolbar actions - single selection : ', () => {
     done();
   });
 
-  xit('');
-
   describe('on Personal Files', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();

diff --git a/e2e/suites/actions/unshare-file.test.ts b/e2e/suites/actions/unshare-file.test.ts
@@ -795,5 +795,4 @@ describe('Unshare a file', () => {
     });
   });
 
-  xit('');
 });
diff --git a/e2e/suites/application/general.test.ts b/e2e/suites/application/general.test.ts
@@ -37,7 +37,6 @@ describe('General', () => {
   const { nodes: nodesApi, authentication: authApi } = adminApi;
   const folder = `folder-${Utils.random()}`;
   let folderId;
-  xit('');
 
   describe('on session expire', () => {
     beforeAll(async (done) => {

diff --git a/e2e/suites/application/page-titles.test.ts b/e2e/suites/application/page-titles.test.ts
@@ -37,8 +37,6 @@ describe('Page titles', () => {
   const file = `file-${Utils.random()}.txt`; let fileId;
   const { searchInput } = page.header;
 
-  xit('');
-
   describe('on Login / Logout pages', () => {
     it('on Login page - [C217155]', async () => {
       await loginPage.load();

diff --git a/e2e/suites/authentication/login.test.ts b/e2e/suites/authentication/login.test.ts
@@ -74,8 +74,6 @@ describe('Login', () => {
     done();
   });
 
-  xit('');
-
   describe('general tests', () => {
     beforeEach(async (done) => {
       await loginPage.load();

diff --git a/e2e/suites/extensions/ext-info-drawer.test.ts b/e2e/suites/extensions/ext-info-drawer.test.ts
@@ -157,6 +157,4 @@ describe('Extensions - Info Drawer', () => {
         });
     });
 
-    xit('');
-
 });
diff --git a/e2e/suites/extensions/ext-viewer.test.ts b/e2e/suites/extensions/ext-viewer.test.ts
@@ -103,8 +103,6 @@ describe('Extensions - Viewer', () => {
         done();
     });
 
-    xit('');
-
     describe('content', () => {
         it('Insert new component in a content viewer - [C284659]', async () => {
             await page.dataTable.doubleClickOnRowByName(pdfFile.file_name);

diff --git a/e2e/suites/list-views/file-libraries.test.ts b/e2e/suites/list-views/file-libraries.test.ts
@@ -96,8 +96,6 @@ describe('File Libraries', () => {
     done();
   });
 
-  xit('');
-
   describe('My Libraries', () => {
     beforeEach(async (done) => {
       await page.goToMyLibrariesAndWait();

diff --git a/e2e/suites/list-views/permissions.test.ts b/e2e/suites/list-views/permissions.test.ts
@@ -41,8 +41,6 @@ describe('Special permissions', () => {
   const page = new BrowsingPage();
   const { dataTable } = page;
 
-  xit('');
-
   beforeAll(async (done) => {
     await apis.admin.people.createUser({ username });
     done();

diff --git a/e2e/suites/list-views/personal-files.test.ts b/e2e/suites/list-views/personal-files.test.ts
@@ -65,8 +65,6 @@ describe('Personal Files', () => {
     done();
   });
 
-  xit('');
-
   describe(`Admin user's personal files`, () => {
     beforeAll(async (done) => {
       await loginPage.loginWithAdmin();

diff --git a/e2e/suites/list-views/tooltips.test.ts b/e2e/suites/list-views/tooltips.test.ts
@@ -85,8 +85,6 @@ describe('File / folder tooltips', () => {
     done();
   });
 
-  xit('');
-
   describe('on Personal Files', () => {
     beforeAll(async (done) => {
       await page.clickPersonalFilesAndWait();

diff --git a/e2e/suites/list-views/trash.test.ts b/e2e/suites/list-views/trash.test.ts
@@ -87,8 +87,6 @@ describe('Trash', () => {
     done();
   });
 
-  xit('');
-
   describe('as admin', () => {
     beforeAll(async (done) => {
       await loginPage.loginWithAdmin();

diff --git a/e2e/suites/viewer/viewer-actions.test.ts b/e2e/suites/viewer/viewer-actions.test.ts
@@ -58,8 +58,6 @@ describe('Viewer actions', () => {
     done();
   });
 
-  xit('');
-
   describe('on Personal Files', () => {
     const parent = `parentPF-${Utils.random()}`; let parentId;
     const destination = `destPF-${Utils.random()}`; let destinationId;

diff --git a/e2e/utilities/repo-client/apis/favorites/favorites-api.ts b/e2e/utilities/repo-client/apis/favorites/favorites-api.ts
@@ -96,7 +96,7 @@ export class FavoritesApi extends RepoApi {
       let isFavorite;
       try {
         const favorite = async () => {
-          isFavorite = JSON.stringify((await this.getFavorites()).list.entries).includes(nodeId);
+          isFavorite = await this.isFavorite(nodeId);
           if ( isFavorite !== data.expect ) {
             return Promise.reject(isFavorite);
           } else {
@@ -114,7 +114,7 @@ export class FavoritesApi extends RepoApi {
     async removeFavoriteById(nodeId: string) {
         await this.apiAuth();
         try {
-          return await this.favoritesApi.deleteSiteFavorite('-me-', nodeId);
+          return await this.favoritesApi.deleteFavorite('-me-', nodeId);
         } catch (error) {
           // console.log('--- remove favorite by id catch ');
         }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -81,7 +81,6 @@
     "jasmine-core": "~2.8.0",
     "jasmine-reporters": "^2.2.1",
     "jasmine-spec-reporter": "~4.2.1",
-    "jasmine2-protractor-utils": "^1.3.0",
     "jasminewd2": "^2.2.0",
     "karma": "^3.0.0",
     "karma-chrome-launcher": "~2.2.0",
@@ -94,6 +93,7 @@
     "pre-commit": "^1.2.2",
     "prettier": "^1.16.0",
     "protractor": "^5.4.0",
+    "protractor-screenshoter-plugin": "0.10.3",
     "rimraf": "2.6.2",
     "rxjs-tslint-rules": "^4.11.0",
     "selenium-webdriver": "4.0.0-alpha.1",
-Original file line number
+Diff line change
@@ Expand Up / @@ -555,6 +555,4 @@ describe('Copy', () => { @@
         });
       });
-      xit('');
     });