Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-2069] fix blue slider issue #854

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Conversation

suzanadirla
Copy link
Contributor

that appeared after upgrading material to 7.1.0

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://issues.alfresco.com/jira/browse/ACA-2069

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

that appeared after upgrading material to 7.1.0
@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@23ad419). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #854   +/-   ##
==============================================
  Coverage               ?   63.98%           
==============================================
  Files                  ?      113           
  Lines                  ?     3968           
  Branches               ?      659           
==============================================
  Hits                   ?     2539           
  Misses                 ?     1306           
  Partials               ?      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ad419...2f642b1. Read the comment docs.

Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please move this style to the "/ui/overrides/adf-share-dialog.theme.scss" or similar so that it is narrowed down to the dialog and in the discoverable place

@suzanadirla
Copy link
Contributor Author

Sure, I'll make the change. Thanks, Denys.

@DenysVuika DenysVuika merged commit 84b0cd4 into development Dec 5, 2018
@DenysVuika DenysVuika deleted the sdirla-slide-toggle-color branch December 5, 2018 14:54
mmuller88 pushed a commit that referenced this pull request May 15, 2019
suzanadirla pushed a commit that referenced this pull request May 16, 2019
* Revert "[ACA-2069] fix blue slider issue (#854)"

This reverts commit 84b0cd4.

* ACA-2111 remove default color for toggle as it defaults to orange

* ACA-2111 remove default color for toggle as it defaults to orange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants