[ACA] add more e2e tests

cspell.json

@@ -35,6 +35,7 @@
     "nginx",
     "docx",
     "SOLR",
+    "simpletask",
 
     "unshare",
     "qshare",

e2e/components/data-table/data-table.ts

@@ -46,6 +46,7 @@ export class DataTable extends Component {
     cell: '.adf-data-table-cell',
     locationLink: '.aca-location-link',
     nameLink: '.dl-link',
+    libraryRole: 'app-library-role-column',
 
     selectedIcon: '.mat-icon',
 
@@ -199,7 +200,6 @@ export class DataTable extends Component {
   async selectItem(name: string) {
     try{
       const item = this.getRowFirstCell(name);
-      // await Utils.waitUntilElementClickable(item);
       await item.click();
 
     } catch (e) {
@@ -315,4 +315,8 @@ export class DataTable extends Component {
     const count = await this.menu.getItemsCount();
     return count > 0;
   }
+
+  async getLibraryRole(name: string) {
+    return await this.getRowByName(name).element(by.css(DataTable.selectors.libraryRole)).getText();
+  }
 }

e2e/components/menu/menu.ts

@@ -58,11 +58,6 @@ export class Menu extends Component {
   }
 
   async closeMenu() {
-    // if (await this.backdrop.isPresent()) {
-    //   return await this.backdrop.click();
-    // } else {
-    //   return await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform();
-    // }
     return Utils.pressEscape();
   }
 
@@ -148,7 +143,7 @@ export class Menu extends Component {
   }
 
   async isMenuItemPresent(title: string) {
-    return await this.component.element(by.cssContainingText(Menu.selectors.item, title)).isPresent();
+    return await browser.element(by.cssContainingText(Menu.selectors.item, title)).isPresent();
   }
 
   async isSubMenuItemPresent(title: string) {

e2e/components/toolbar/toolbar.ts

@@ -30,7 +30,8 @@ import { Component } from '../component';
 export class Toolbar extends Component {
   private static selectors = {
     root: '.adf-toolbar',
-    button: '.mat-icon-button'
+    // button: '.mat-icon-button'
+    button: 'button'
   };
 
   menu: Menu = new Menu();

e2e/suites/actions/context-menu-multiple-selection.test.ts

@@ -66,7 +66,7 @@ describe('Context menu actions - multiple selection : ', () => {
     folder2Id = (await apis.user.nodes.createFolder(folder2)).entry.id;
 
     await apis.user.sites.createSite(siteName, SITE_VISIBILITY.PUBLIC);
-    const docLibId = (await apis.user.sites.getDocLibId(siteName));
+    const docLibId = await apis.user.sites.getDocLibId(siteName);
     await apis.user.nodes.createFile(file1Site, docLibId);
     await apis.user.nodes.createFile(file2Site, docLibId);
     await apis.user.nodes.createFolder(folder1Site, docLibId);

e2e/suites/actions/context-menu-single-selection.test.ts

@@ -40,6 +40,9 @@ describe('Context menu actions - single selection : ', () => {
   const fileSiteUser = `fileUser-${Utils.random()}.txt`;
   const folderSiteUser = `folderUser-${Utils.random()}`;
 
+  const adminPublic = `admin-public-${Utils.random()}`;
+  const adminModerated = `admin-moderated-${Utils.random()}`;
+
   const apis = {
     admin: new RepoClient(),
     user: new RepoClient(username, username)
@@ -73,6 +76,12 @@ describe('Context menu actions - single selection : ', () => {
     await apis.user.favorites.addFavoriteById('folder', folderUserId);
     await apis.user.favorites.waitForApi({ expect: 3 });
 
+    await apis.admin.sites.createSite(adminPublic);
+    await apis.admin.sites.createSite(adminModerated, SITE_VISIBILITY.MODERATED);
+    await apis.user.favorites.addFavoriteById('site', adminPublic);
+    await apis.user.favorites.addFavoriteById('site', adminModerated);
+    await apis.user.sites.requestToJoin(adminModerated);
+
     await loginPage.loginWith(username);
     done();
   });
@@ -81,6 +90,8 @@ describe('Context menu actions - single selection : ', () => {
     await apis.user.nodes.deleteNodeById(fileUserId);
     await apis.user.nodes.deleteNodeById(folderUserId);
     await apis.user.sites.deleteSite(siteName);
+    await apis.admin.sites.deleteSite(adminPublic);
+    await apis.admin.sites.deleteSite(adminModerated);
     await apis.user.trashcan.emptyTrash();
     done();
   });
@@ -125,12 +136,6 @@ describe('Context menu actions - single selection : ', () => {
       await page.sidenav.getActiveLink().click();
       expect(await dataTable.hasContextMenu()).toBe(false, 'Context menu is displayed');
     });
-
-    it('Context menu appears for a library - [C286276]', async () => {
-      await page.clickFileLibrariesAndWait();
-      await dataTable.rightClickOnItem(siteName);
-      expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is displayed for a site');
-    });
   });
 
   describe('on Personal Files', () => {
@@ -171,7 +176,7 @@ describe('Context menu actions - single selection : ', () => {
     });
   });
 
-  describe('File Libraries', () => {
+  describe('on File Libraries', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();
       await page.clickFileLibrariesAndWait();
@@ -210,7 +215,51 @@ describe('Context menu actions - single selection : ', () => {
     });
   });
 
-  describe('Shared Files', () => {
+  describe('on a library', () => {
+    beforeEach(async (done) => {
+      await Utils.pressEscape();
+      await dataTable.clearSelection();
+      done();
+    });
+
+    it('Available actions when a library is selected - My Libraries - [C290080]', async () => {
+      await page.goToMyLibraries();
+      await dataTable.rightClickOnItem(siteName);
+      expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed');
+      expect(await contextMenu.isMenuItemPresent('Leave library')).toBe(true, `Leave is not displayed for ${siteName}`);
+      expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${siteName}`);
+      expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${siteName}`);
+    });
+
+    it('Available actions when a library is selected - Favorite Libraries - user is a member - [C290081]', async () => {
+      await page.goToFavoriteLibraries();
+      await dataTable.rightClickOnItem(siteName);
+      expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed');
+      expect(await contextMenu.isMenuItemPresent('Leave library')).toBe(true, `Leave is not displayed for ${siteName}`);
+      expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${siteName}`);
+      expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${siteName}`);
+    });
+
+    it('Available actions when a library is selected - Favorite Libraries - user is not a member - [C290082]', async () => {
+      await page.goToFavoriteLibraries();
+      await dataTable.rightClickOnItem(adminPublic);
+      expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed');
+      expect(await contextMenu.isMenuItemPresent('Join')).toBe(true, `Join is not displayed for ${adminPublic}`);
+      expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${adminPublic}`);
+      expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${adminPublic}`);
+    });
+
+    it('Available actions when a library is selected - Favorite Libraries - user requested to join - [C290089]', async () => {
+      await page.goToFavoriteLibraries();
+      await dataTable.rightClickOnItem(adminModerated);
+      expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed');
+      expect(await contextMenu.isMenuItemPresent('Cancel join')).toBe(true, `Cancel join is not displayed for ${adminModerated}`);
+      expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${adminModerated}`);
+      expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${adminModerated}`);
+    });
+  });
+
+  describe('on Shared Files', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();
       await page.clickSharedFilesAndWait();
@@ -234,7 +283,7 @@ describe('Context menu actions - single selection : ', () => {
     });
   });
 
-  describe('Recent Files', () => {
+  describe('on Recent Files', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();
       await page.clickRecentFilesAndWait();
@@ -257,7 +306,7 @@ describe('Context menu actions - single selection : ', () => {
     });
   });
 
-  describe('Favorites', () => {
+  describe('on Favorites', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();
       await page.clickFavoritesAndWait();
@@ -296,7 +345,7 @@ describe('Context menu actions - single selection : ', () => {
     });
   });
 
-  describe('Trash', () => {
+  describe('on Trash', () => {
     beforeEach(async (done) => {
       await Utils.pressEscape();
       await page.clickTrashAndWait();

e2e/suites/actions/create-folder.test.ts

@@ -23,11 +23,9 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { browser } from 'protractor';
 import { SITE_VISIBILITY, SITE_ROLES } from '../../configs';
 import { LoginPage, BrowsingPage } from '../../pages/pages';
 import { CreateOrEditFolderDialog } from '../../components/dialog/create-edit-folder-dialog';
-import { Menu } from '../../components/menu/menu';
 import { Utils } from '../../utilities/utils';
 import { RepoClient } from '../../utilities/repo-client/repo-client';
 
@@ -41,7 +39,12 @@ describe('Create folder', () => {
   const duplicateFolderName = `folder-${Utils.random()}`;
   const nameWithSpaces = ` folder-${Utils.random()} `;
 
-  const siteName = `site-private-${Utils.random()}`;
+  const sitePrivate = `site-private-${Utils.random()}`;
+  const siteName = `site-${Utils.random()}`;
+
+  const folderSite = `folder-site-${Utils.random()}`;
+  const duplicateFolderSite = `folder-${Utils.random()}`;
+  let docLibUserSite;
 
   const apis = {
     admin: new RepoClient(),
@@ -52,22 +55,29 @@ describe('Create folder', () => {
   const page = new BrowsingPage();
   const createDialog = new CreateOrEditFolderDialog();
   const { dataTable } = page;
-  const menu = new Menu();
 
   beforeAll(async (done) => {
     await apis.admin.people.createUser({ username });
-    await apis.admin.sites.createSite(siteName, SITE_VISIBILITY.PRIVATE);
-    const docLibId = (await apis.admin.sites.getDocLibId(siteName));
+
+    await apis.admin.sites.createSite(sitePrivate, SITE_VISIBILITY.PRIVATE);
+    const docLibId = await apis.admin.sites.getDocLibId(sitePrivate);
     await apis.admin.nodes.createFolder(folderName1, docLibId);
-    await apis.admin.sites.addSiteMember(siteName, username, SITE_ROLES.SITE_CONSUMER.ROLE);
+    await apis.admin.sites.addSiteMember(sitePrivate, username, SITE_ROLES.SITE_CONSUMER.ROLE);
+
     parentId = (await apis.user.nodes.createFolder(parent)).entry.id;
     await apis.user.nodes.createFolder(duplicateFolderName, parentId);
+
+    await apis.user.sites.createSite(siteName);
+    docLibUserSite = await apis.user.sites.getDocLibId(siteName);
+    await apis.user.nodes.createFolder(duplicateFolderSite, docLibUserSite);
+
     await loginPage.loginWith(username);
     done();
   });
 
   afterAll(async (done) => {
-    await apis.admin.sites.deleteSite(siteName);
+    await apis.admin.sites.deleteSite(sitePrivate);
+    await apis.user.sites.deleteSite(siteName);
     await apis.user.nodes.deleteNodeById(parentId);
     done();
   });
@@ -83,13 +93,6 @@ describe('Create folder', () => {
       done();
     });
 
-    it('option is enabled when having enough permissions - [C216339]', async () => {
-      await page.dataTable.doubleClickOnRowByName(parent);
-      await page.sidenav.openNewMenu();
-      const isEnabled = await menu.getItemByLabel('Create folder').isEnabled();
-      expect(isEnabled).toBe(true, 'Create folder is not enabled');
-    });
-
     it('creates new folder with name - [C216341]', async () => {
       await page.dataTable.doubleClickOnRowByName(parent);
       await page.sidenav.openCreateFolderDialog();
@@ -112,18 +115,11 @@ describe('Create folder', () => {
       await createDialog.waitForDialogToClose();
       await dataTable.waitForHeader();
       expect(await dataTable.getRowByName(folderName2).isPresent()).toBe(true, 'Folder not displayed');
-      const desc = await apis.user.nodes.getNodeDescription(folderName2, parent);
+      const desc = await apis.user.nodes.getNodeDescription(folderName2, parentId);
       expect(desc).toEqual(folderDescription);
       done();
     });
 
-    it('enabled option tooltip - [C216342]', async () => {
-      await page.dataTable.doubleClickOnRowByName(parent);
-      await page.sidenav.openNewMenu();
-      await browser.actions().mouseMove(menu.getItemByLabel('Create folder')).perform();
-      expect(await menu.getItemTooltip('Create folder')).toContain('Create new folder');
-    });
-
     it('dialog UI elements - [C216345]', async () => {
       await page.dataTable.doubleClickOnRowByName(parent);
       await page.sidenav.openCreateFolderDialog();
@@ -238,21 +234,39 @@ describe('Create folder', () => {
       done();
     });
 
-    it('option is disabled when not enough permissions - [C280397]', async () => {
-      await fileLibrariesPage.dataTable.doubleClickOnRowByName(siteName);
-      await fileLibrariesPage.dataTable.doubleClickOnRowByName(folderName1);
-      await fileLibrariesPage.sidenav.openNewMenu();
-      const isEnabled = await menu.getItemByLabel('Create folder').isEnabled();
-      expect(isEnabled).toBe(false, 'Create folder is not disabled');
+    it('creates new folder with name and description - [C280394]', async () => {
+      await page.dataTable.doubleClickOnRowByName(siteName);
+      await page.sidenav.openCreateFolderDialog();
+      await createDialog.waitForDialogToOpen();
+      await createDialog.enterName(folderSite);
+      await createDialog.enterDescription(folderDescription);
+      await createDialog.clickCreate();
+      await createDialog.waitForDialogToClose();
+      await dataTable.waitForHeader();
+      expect(await dataTable.getRowByName(folderSite).isPresent()).toBe(true, 'Folder not displayed');
+      const desc = await apis.user.nodes.getNodeDescription(folderSite, docLibUserSite);
+      expect(desc).toEqual(folderDescription);
+    });
+
+    it('cancel folder creation - [C280403]', async () => {
+      await page.dataTable.doubleClickOnRowByName(siteName);
+      await page.sidenav.openCreateFolderDialog();
+      await createDialog.waitForDialogToOpen();
+      await createDialog.enterName('test');
+      await createDialog.enterDescription('test description');
+      await createDialog.clickCancel();
+      expect(await createDialog.isDialogOpen()).not.toBe(true, 'dialog is not closed');
     });
 
-    it('disabled option tooltip - [C280398]', async () => {
-      await fileLibrariesPage.dataTable.doubleClickOnRowByName(siteName);
-      await fileLibrariesPage.dataTable.doubleClickOnRowByName(folderName1);
-      await fileLibrariesPage.sidenav.openNewMenu();
-      await browser.actions().mouseMove(menu.getItemByLabel('Create folder')).perform();
-      const tooltip = await menu.getItemTooltip('Create folder');
-      expect(tooltip).toContain(`Folders cannot be created whilst viewing the current items`);
+    it('duplicate folder name - [C280404]', async () => {
+      await page.dataTable.doubleClickOnRowByName(siteName);
+      await page.sidenav.openCreateFolderDialog();
+      await createDialog.waitForDialogToOpen();
+      await createDialog.enterName(duplicateFolderSite);
+      await createDialog.clickCreate();
+      const message = await page.getSnackBarMessage();
+      expect(message).toEqual(`There's already a folder with this name. Try a different name.`);
+      expect(await createDialog.isDialogOpen()).toBe(true, 'dialog is not present');
     });
   });
 

e2e/suites/actions/create-library.test.ts

@@ -23,11 +23,9 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { browser } from 'protractor';
 import { SITE_VISIBILITY } from '../../configs';
 import { LoginPage, BrowsingPage } from '../../pages/pages';
 import { CreateLibraryDialog } from '../../components/dialog/create-library-dialog';
-import { Menu } from '../../components/menu/menu';
 import { Utils } from '../../utilities/utils';
 import { RepoClient } from '../../utilities/repo-client/repo-client';
 
@@ -62,7 +60,6 @@ describe('Create library', () => {
   const loginPage = new LoginPage();
   const page = new BrowsingPage();
   const createDialog = new CreateLibraryDialog();
-  const menu = new Menu();
   const { dataTable } = page;
 
   beforeAll(async (done) => {
@@ -215,10 +212,4 @@ describe('Create library', () => {
     expect(await apis.user.sites.getTitle(`${duplicateSite.id}-2`)).toEqual(duplicateSite.name);
   });
 
-  it('Tooltip for "Create Library" button - [C286526]', async () => {
-    await page.sidenav.openNewMenu();
-    await browser.actions().mouseMove(menu.getItemByLabel('Create Library')).perform();
-    expect(await menu.getItemTooltip('Create Library')).toContain('Create a new File Library');
-  });
-
 });