Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-1057] Upload - snack-bar error messages #837

Merged
merged 3 commits into from
Nov 28, 2018

Conversation

pionnegru
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #837 into development will increase coverage by 0.51%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #837      +/-   ##
===============================================
+ Coverage        62.84%   63.35%   +0.51%     
===============================================
  Files              113      113              
  Lines             3921     3927       +6     
  Branches           645      648       +3     
===============================================
+ Hits              2464     2488      +24     
+ Misses            1335     1317      -18     
  Partials           122      122
Impacted Files Coverage Δ
src/app/app.component.ts 50% <100%> (+36.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0bfe8...e6114d3. Read the comment docs.

@DenysVuika DenysVuika merged commit 4c77ace into development Nov 28, 2018
@DenysVuika DenysVuika deleted the dev-pionnegru-upload-snackbar branch November 28, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants