Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-1968] style search input for smaller screens #833

Merged
merged 8 commits into from
Nov 29, 2018

Conversation

suzanadirla
Copy link
Contributor

@suzanadirla suzanadirla commented Nov 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://issues.alfresco.com/jira/browse/ACA-1968

What is the new behavior?

'max-width: 959px' screens:
small_screens-collapsed
small_screens

'max-width: 599px' screens:
xsmall_screens-collapsed
xsmall_screens

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@6c821d0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #833   +/-   ##
==============================================
  Coverage               ?   63.47%           
==============================================
  Files                  ?      113           
  Lines                  ?     3937           
  Branches               ?      651           
==============================================
  Hits                   ?     2499           
  Misses                 ?     1316           
  Partials               ?      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c821d0...452e187. Read the comment docs.

@DenysVuika DenysVuika requested a review from pionnegru November 28, 2018 12:46
@DenysVuika
Copy link
Contributor

Looks and works really cool!

@DenysVuika DenysVuika merged commit 462cc09 into development Nov 29, 2018
@DenysVuika DenysVuika deleted the sdirla-style-search-input branch November 29, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants