Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-805] about screen improvements #818

Merged
merged 6 commits into from
Nov 22, 2018
Merged

Conversation

DenysVuika
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • support i18n for all the tables
  • migrate all tables to Material Table component
  • simplify table layouts

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@54892e7). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #818   +/-   ##
==============================================
  Coverage               ?   63.03%           
==============================================
  Files                  ?      113           
  Lines                  ?     3860           
  Branches               ?      634           
==============================================
  Hits                   ?     2433           
  Misses                 ?     1311           
  Partials               ?      116
Impacted Files Coverage Δ
src/app/components/about/about.component.ts 18.75% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54892e7...ad6a499. Read the comment docs.

@pionnegru pionnegru merged commit f0f9867 into development Nov 22, 2018
@DenysVuika DenysVuika deleted the denys-about-screen branch February 5, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants