Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-805] about screen enhancements #813

Merged
merged 8 commits into from
Nov 20, 2018
Merged

Conversation

DenysVuika
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • update to latest @alfresco/adf-extensions (new features for plugin management and metadata)
  • display all loaded extensions and metadata
  • i18n fixes for about screen
  • rework "Dependencies" section, reduce the 1MB of data download each time

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@DenysVuika DenysVuika requested a review from pionnegru November 20, 2018 13:55
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (development@01ea887). Click here to learn what that means.
The diff coverage is 30.76%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #813   +/-   ##
==============================================
  Coverage               ?   62.86%           
==============================================
  Files                  ?      113           
  Lines                  ?     3856           
  Branches               ?      631           
==============================================
  Hits                   ?     2424           
  Misses                 ?     1317           
  Partials               ?      115
Impacted Files Coverage Δ
src/app/store/actions/repository.actions.ts 66.66% <ø> (ø)
src/app/store/states/app.state.ts 100% <ø> (ø)
src/app/components/about/about.component.ts 16.66% <0%> (ø)
src/app/extensions/extension.service.ts 64.07% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ea887...5b2a340. Read the comment docs.

@pionnegru pionnegru merged commit 26b4b06 into development Nov 20, 2018
@pionnegru pionnegru deleted the denys-extensions-metadata branch November 20, 2018 19:15
suzanadirla pushed a commit that referenced this pull request Nov 21, 2018
* upgrade to latest adf-extensions

* switch to ADF RepositoryState

* show extensions on About page, i18n fixes

* update docs

* cleanup about styles

* greatly simplify app dependencies rendering

* fix linting

* fix tests
suzanadirla pushed a commit that referenced this pull request Nov 21, 2018
* upgrade to latest adf-extensions

* switch to ADF RepositoryState

* show extensions on About page, i18n fixes

* update docs

* cleanup about styles

* greatly simplify app dependencies rendering

* fix linting

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants