Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-20] Add/Remove favorite library #804

Merged
merged 9 commits into from
Nov 16, 2018

Conversation

pionnegru
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #804 into development will increase coverage by 0.37%.
The diff coverage is 86.53%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #804      +/-   ##
===============================================
+ Coverage        61.16%   61.54%   +0.37%     
===============================================
  Files              111      113       +2     
  Lines             3749     3799      +50     
  Branches           616      620       +4     
===============================================
+ Hits              2293     2338      +45     
- Misses            1348     1352       +4     
- Partials           108      109       +1
Impacted Files Coverage Δ
src/app/extensions/core.extensions.module.ts 80% <ø> (ø) ⬆️
...favorite-libraries/favorite-libraries.component.ts 75% <0%> (-3.27%) ⬇️
...rc/app/components/libraries/libraries.component.ts 50% <0%> (ø) ⬆️
...orite-library/toggle-favorite-library.component.ts 100% <100%> (ø)
src/app/services/content-management.service.ts 67.99% <100%> (+0.07%) ⬆️
src/app/directives/library-favorite.directive.ts 90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac59bd...ec36961. Read the comment docs.

@suzanadirla suzanadirla merged commit da41834 into development Nov 16, 2018
@suzanadirla suzanadirla deleted the dev-pionnegru-ACA-20-add-remove-favorite branch November 16, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants