-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-19] show search libraries hint #802
Conversation
Codecov Report
@@ Coverage Diff @@
## development #802 +/- ##
===============================================
+ Coverage 61.54% 62.72% +1.18%
===============================================
Files 113 113
Lines 3799 3818 +19
Branches 620 622 +2
===============================================
+ Hits 2338 2395 +57
+ Misses 1352 1312 -40
- Partials 109 111 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see comments for potential issue with memory leaks
src/app/components/search/search-input/search-input.component.ts
Outdated
Show resolved
Hide resolved
cdd8751
to
bd43a5b
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: https://issues.alfresco.com/jira/browse/ACA-1989
What is the new behavior?
fixes the Jira issue
Does this PR introduce a breaking change?
Other information