Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor library dialog #795

Merged
merged 5 commits into from
Nov 14, 2018
Merged

refactor library dialog #795

merged 5 commits into from
Nov 14, 2018

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Nov 9, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Prepare the dialog for ADF contribution
  • Disable browser auto-completion for Name/ID fields
  • Uppercase for dialog buttons
  • Merge with validators
  • Remove dependency on local ContentApi service (not present in ADF)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@031198e). Click here to learn what that means.
The diff coverage is 82.35%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #795   +/-   ##
==============================================
  Coverage               ?   61.73%           
==============================================
  Files                  ?      109           
  Lines                  ?     3664           
  Branches               ?      603           
==============================================
  Hits                   ?     2262           
  Misses                 ?     1294           
  Partials               ?      108
Impacted Files Coverage Δ
src/app/dialogs/library/library.dialog.ts 83.54% <82.35%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031198e...5ec915b. Read the comment docs.

@DenysVuika DenysVuika merged commit 7734844 into development Nov 14, 2018
@DenysVuika DenysVuika deleted the denys-library-dialog branch November 14, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants