Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-20] Favorite Libraries #789

Merged
merged 45 commits into from
Nov 9, 2018

Conversation

pionnegru
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #789 into development will increase coverage by 0.76%.
The diff coverage is 65.95%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #789      +/-   ##
===============================================
+ Coverage        53.01%   53.77%   +0.76%     
===============================================
  Files              108      110       +2     
  Lines             3003     3046      +43     
  Branches           596      601       +5     
===============================================
+ Hits              1592     1638      +46     
+ Misses            1328     1315      -13     
- Partials            83       93      +10
Impacted Files Coverage Δ
src/app/extensions/core.extensions.module.ts 71.42% <ø> (ø) ⬆️
src/app/extensions/extension.service.ts 57.66% <ø> (ø) ⬆️
src/app/services/content-api.service.ts 6% <0%> (-0.67%) ⬇️
src/app/directives/document-list.directive.ts 7.54% <0%> (-0.3%) ⬇️
...rc/app/components/libraries/libraries.component.ts 38.46% <0%> (+2.74%) ⬆️
...favorite-libraries/favorite-libraries.component.ts 75% <75%> (ø)
...brary-role-column/library-role-column.component.ts 94.11% <94.11%> (ø)
src/app/store/effects/library.effects.ts 50% <0%> (+14.28%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9313b64...e2bdfae. Read the comment docs.

Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@DenysVuika DenysVuika merged commit 4a420cc into development Nov 9, 2018
@DenysVuika DenysVuika deleted the dev-pionnegru-ACA-20-favorite-libraries branch November 9, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants