Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission manager fixes #778

Merged
merged 2 commits into from
Nov 5, 2018
Merged

permission manager fixes #778

merged 2 commits into from
Nov 5, 2018

Conversation

DenysVuika
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • fir i18n for "add" button
  • fix dialog layout (ADF issue workaround)

Before:

screenshot 2018-11-03 at 08 26 53

After:

screenshot 2018-11-03 at 08 39 06

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 3, 2018

Codecov Report

Merging #778 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #778   +/-   ##
============================================
  Coverage        52.54%   52.54%           
============================================
  Files              106      106           
  Lines             2908     2908           
  Branches           575      575           
============================================
  Hits              1528     1528           
  Misses            1301     1301           
  Partials            79       79
Impacted Files Coverage Δ
...permission-manager/permission-manager.component.ts 17.64% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a9ade...31bc3c4. Read the comment docs.

@suzanadirla suzanadirla merged commit e33c91e into development Nov 5, 2018
@suzanadirla suzanadirla deleted the denys-permission-fixes branch November 5, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants