Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-1957] Library metadata - check title uniqueness #767

Merged
merged 4 commits into from
Oct 30, 2018

Conversation

pionnegru
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #767 into development will increase coverage by 0.21%.
The diff coverage is 94.11%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #767      +/-   ##
==============================================
+ Coverage        51.09%   51.3%   +0.21%     
==============================================
  Files              106     106              
  Lines             2965    2980      +15     
  Branches           593     595       +2     
==============================================
+ Hits              1515    1529      +14     
- Misses            1372    1373       +1     
  Partials            78      78
Impacted Files Coverage Δ
...ry-metadata-tab/library-metadata-form.component.ts 93.93% <94.11%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d68ada...cc51814. Read the comment docs.

@DenysVuika DenysVuika merged commit b5cf1bf into development Oct 30, 2018
@DenysVuika DenysVuika deleted the dev-pionnegru-ACA-1957-metadata branch February 5, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants