Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA] small improvements #762

Merged
merged 1 commit into from
Oct 29, 2018
Merged

[ACA] small improvements #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion e2e/suites/list-views/empty-list.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('Empty list views', () => {
const loginPage = new LoginPage();
const logoutPage = new LogoutPage();
const page = new BrowsingPage();
const { dataTable } = page;
const { dataTable, pagination } = page;

beforeAll(async (done) => {
await apis.admin.people.createUser({ username });
Expand Down Expand Up @@ -93,4 +93,64 @@ describe('Empty list views', () => {
expect(await dataTable.getEmptyStateText()).toContain('Items you delete are moved to the Trash.');
expect(await dataTable.getEmptyStateText()).toContain('Empty Trash to permanently delete items.');
});

it('Favorites - pagination controls not displayed - [C280111]', async () => {
await page.clickFavorites();
expect(await pagination.range.isPresent()).toBe(false);
expect(await pagination.maxItems.isPresent()).toBe(false);
expect(await pagination.currentPage.isPresent()).toBe(false);
expect(await pagination.totalPages.isPresent()).toBe(false);
expect(await pagination.previousButton.isPresent()).toBe(false);
expect(await pagination.nextButton.isPresent()).toBe(false);
});

it('File Libraries - pagination controls not displayed - [C280084]', async () => {
await page.clickFileLibraries();
expect(await pagination.range.isPresent()).toBe(false);
expect(await pagination.maxItems.isPresent()).toBe(false);
expect(await pagination.currentPage.isPresent()).toBe(false);
expect(await pagination.totalPages.isPresent()).toBe(false);
expect(await pagination.previousButton.isPresent()).toBe(false);
expect(await pagination.nextButton.isPresent()).toBe(false);
});

it('Personal Files - pagination controls not displayed - [C280075]', async () => {
await page.clickPersonalFiles();
expect(await pagination.range.isPresent()).toBe(false);
expect(await pagination.maxItems.isPresent()).toBe(false);
expect(await pagination.currentPage.isPresent()).toBe(false);
expect(await pagination.totalPages.isPresent()).toBe(false);
expect(await pagination.previousButton.isPresent()).toBe(false);
expect(await pagination.nextButton.isPresent()).toBe(false);
});

it('Recent Files - pagination controls not displayed - [C280102]', async () => {
await page.clickRecentFiles();
expect(await pagination.range.isPresent()).toBe(false);
expect(await pagination.maxItems.isPresent()).toBe(false);
expect(await pagination.currentPage.isPresent()).toBe(false);
expect(await pagination.totalPages.isPresent()).toBe(false);
expect(await pagination.previousButton.isPresent()).toBe(false);
expect(await pagination.nextButton.isPresent()).toBe(false);
});

it('Shared Files - pagination controls not displayed - [C280094]', async () => {
await page.clickSharedFiles();
expect(await pagination.range.isPresent()).toBe(false);
expect(await pagination.maxItems.isPresent()).toBe(false);
expect(await pagination.currentPage.isPresent()).toBe(false);
expect(await pagination.totalPages.isPresent()).toBe(false);
expect(await pagination.previousButton.isPresent()).toBe(false);
expect(await pagination.nextButton.isPresent()).toBe(false);
});

it('Trash - pagination controls not displayed - [C280120]', async () => {
await page.clickTrash();
expect(await pagination.range.isPresent()).toBe(false);
expect(pagination.maxItems.isPresent()).toBe(false);
expect(pagination.currentPage.isPresent()).toBe(false);
expect(pagination.totalPages.isPresent()).toBe(false);
expect(pagination.previousButton.isPresent()).toBe(false);
expect(pagination.nextButton.isPresent()).toBe(false);
});
});
2 changes: 1 addition & 1 deletion e2e/suites/list-views/favorites.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ describe('Favorites', () => {

it('Location column redirect - file in site - [C280485]', async () => {
await dataTable.clickItemLocation(fileName1);
expect(breadcrumb.getAllItems()).toEqual([ 'File Libraries', siteName ]);
expect(await breadcrumb.getAllItems()).toEqual([ 'File Libraries', siteName ]);
});

it('Navigate into folder from Favorites - [C213230]', async () => {
Expand Down
111 changes: 0 additions & 111 deletions e2e/suites/pagination/pag-empty-page.test.ts
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@
},
"PERMISSIONS": {
"DIALOG": {
"TITLE": "Manage Permissons",
"TITLE": "Manage Permissions",
"CLOSE": "Close",
"INHERIT_PERMISSIONS_BUTTON": "Inherit Permission",
"INHERITED_PERMISSIONS_BUTTON": "Permission Inherited"
"INHERIT_PERMISSIONS_BUTTON": "Inherit Permissions",
"INHERITED_PERMISSIONS_BUTTON": "Permissions Inherited"
}
},
"SHARED_LINK": {
Expand Down Expand Up @@ -296,7 +296,7 @@
},
"ERRORS": {
"GENERIC": "We hit a problem",
"EXISTENT_SITE": "This Library ID isn't available. Try a different Library.",
"EXISTENT_SITE": "This Library ID isn't available. Try a different Library ID.",
"CONFLICT": "This Library ID is already used. Check the trashcan.",
"ID_TOO_LONG": "Use 72 characters or less for the URL name",
"DESCRIPTION_TOO_LONG": "Use 512 characters or less for description",
Expand Down