-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-1956] Library - metadata info #760
Conversation
Codecov Report
@@ Coverage Diff @@
## development #760 +/- ##
==============================================
+ Coverage 50.29% 51.3% +1.01%
==============================================
Files 103 106 +3
Lines 2899 2953 +54
Branches 585 592 +7
==============================================
+ Hits 1458 1515 +57
+ Misses 1367 1360 -7
- Partials 74 78 +4
Continue to review full report at Codecov.
|
this.displayNode = node; | ||
} | ||
|
||
private isLibraryListNode(node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misses typing
return node.isLibrary; | ||
} | ||
|
||
private isFavoriteListNode(node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misses typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename tab from "About" to "Properties" for consistency purposes
…ntent-app into dev-pionnegru-ACA-1956 # Conflicts: # src/app/components/libraries/libraries.component.html
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information