Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-1956] Library - metadata info #760

Merged
merged 21 commits into from
Oct 29, 2018
Merged

Conversation

pionnegru
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #760 into development will increase coverage by 1.01%.
The diff coverage is 68.25%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #760      +/-   ##
==============================================
+ Coverage        50.29%   51.3%   +1.01%     
==============================================
  Files              103     106       +3     
  Lines             2899    2953      +54     
  Branches           585     592       +7     
==============================================
+ Hits              1458    1515      +57     
+ Misses            1367    1360       -7     
- Partials            74      78       +4
Impacted Files Coverage Δ
src/app/extensions/core.extensions.module.ts 71.42% <ø> (ø) ⬆️
...rc/app/components/libraries/libraries.component.ts 35.71% <0%> (-5.96%) ⬇️
src/app/services/content-api.service.ts 6.66% <0%> (-0.16%) ⬇️
src/app/extensions/extension.service.ts 51.16% <0%> (ø) ⬆️
src/app/store/reducers/app.reducer.ts 35.29% <0%> (-2.21%) ⬇️
...pp/components/info-drawer/info-drawer.component.ts 88.88% <100%> (+78.17%) ⬆️
...ary-metadata-tab/library-metadata-tab.component.ts 100% <100%> (ø)
src/app/store/actions/library.actions.ts 54.54% <100%> (+17.04%) ⬆️
src/app/store/actions/info-drawer.actions.ts 100% <100%> (ø)
src/app/store/effects/library.effects.ts 35.71% <14.28%> (-7.15%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ada58f...ea9f9b6. Read the comment docs.

this.displayNode = node;
}

private isLibraryListNode(node) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misses typing

return node.isLibrary;
}

private isFavoriteListNode(node) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misses typing

Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename tab from "About" to "Properties" for consistency purposes

…ntent-app into dev-pionnegru-ACA-1956

# Conflicts:
#	src/app/components/libraries/libraries.component.html
@pionnegru pionnegru merged commit 1807456 into development Oct 29, 2018
@pionnegru pionnegru deleted the dev-pionnegru-ACA-1956 branch October 29, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants