[ACS-8991] Fix sidenav issue when clicking on manage saved searches #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
requested review from
nikita-web-ua,
swapnil-verma-gl,
AleksanderSklorz and
dominikiwanekhyland
|
|
Not sure if this is the write PR to post this or not, but I noticed a behaviour issue in regards to search. After doing a search, If i open the search input layover, and select the file/folder checkbox, then there is no loading bar shown while fetching the results. There is a search query fired in the background as the search results change accordingly after some time. This behaviour is not present on ACADEV. Also, this behaviour only applies to file/folder checkbox. The libraries checkbox works as expected. See video search-bar.mp4 |
AleksanderSklorz
approved these changes
Nov 18, 2024
nikita-web-ua
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://hyland.atlassian.net/browse/ACS-8991, depends on Alfresco/alfresco-ng2-components#10393