Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8924] Failing Sonar job #4219

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
[value]="option"
[title]="option.tooltip | translate"
[attr.data-automation-id]="option.id"
(keyup.enter)="runAction(option)"
(click)="runAction(option)"
>
<div class="aca-bulk-actions-option-content">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
[(ngModel)]="option.value"
[disabled]="option.shouldDisable()"
(change)="searchByOption()"
(keyup.enter)="$event.stopPropagation()"
(click)="$event.stopPropagation()"
>
{{ option.key | translate }}
Expand Down
4 changes: 2 additions & 2 deletions projects/aca-playwright-shared/src/api/favorites-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class FavoritesPageApi {
return Promise.resolve(isFavorite);
}
};
return Utils.retryCall(favorite);
return await Utils.retryCall(favorite);
} catch (error) {}
return isFavorite;
}
Expand All @@ -112,7 +112,7 @@ export class FavoritesPageApi {
return Promise.resolve(totalItems);
}
};
return Utils.retryCall(favoriteFiles);
return await Utils.retryCall(favoriteFiles);
} catch {}
}

Expand Down
2 changes: 1 addition & 1 deletion projects/aca-playwright-shared/src/api/file-actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class FileActionsApi {
return Promise.resolve(isLocked);
}
};
return Utils.retryCall(locked, data.retry);
return await Utils.retryCall(locked, data.retry);
} catch {}
return isLocked;
}
Expand Down
8 changes: 4 additions & 4 deletions projects/aca-playwright-shared/src/api/nodes-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class NodesApi {
aspectNames: string[] = null
): Promise<NodeEntry | null> {
try {
return this.createNode('cm:folder', name, parentId, title, description, null, author, null, aspectNames);
return await this.createNode('cm:folder', name, parentId, title, description, null, author, null, aspectNames);
} catch (error) {
console.error(`${this.constructor.name} ${this.createFolder.name}`, error);
return null;
Expand All @@ -65,7 +65,7 @@ export class NodesApi {
aspectNames: string[] = null
): Promise<NodeEntry> {
try {
return this.createNode('cm:content', name, parentId, title, description, null, author, majorVersion, aspectNames);
return await this.createNode('cm:content', name, parentId, title, description, null, author, majorVersion, aspectNames);
} catch (error) {
console.error(`${this.constructor.name} ${this.createFile.name}`, error);
return null;
Expand All @@ -74,7 +74,7 @@ export class NodesApi {

async createFiles(names: string[], relativePath = '/'): Promise<NodePaging> {
try {
return this.createContent({ files: names }, relativePath);
return await this.createContent({ files: names }, relativePath);
} catch (error) {
console.error(`${this.constructor.name} ${this.createFiles.name}: ${error}`);
return null;
Expand All @@ -83,7 +83,7 @@ export class NodesApi {

async createFolders(names: string[], relativePath = '/'): Promise<NodePaging> {
try {
return this.createContent({ folders: names }, relativePath);
return await this.createContent({ folders: names }, relativePath);
} catch (error) {
console.error(`${this.constructor.name} ${this.createFolders.name}: ${error}`);
return null;
Expand Down
2 changes: 1 addition & 1 deletion projects/aca-playwright-shared/src/api/queries-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class QueriesApi {
}
};

return Utils.retryCall(sites);
return await Utils.retryCall(sites);
} catch (error) {
console.error(`QueriesApi waitForSites : catch : `);
console.error(`\tExpected: ${data.expect} items, but found ${error}`);
Expand Down
2 changes: 1 addition & 1 deletion projects/aca-playwright-shared/src/api/search-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class SearchPageApi {
}
};

return Utils.retryCall(searchFiles);
return await Utils.retryCall(searchFiles);
} catch {}
}
}
4 changes: 2 additions & 2 deletions projects/aca-playwright-shared/src/api/shared-links-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class SharedLinksApi {
}
};

return Utils.retryCall(sharedFile);
return await Utils.retryCall(sharedFile);
} catch (error) {
console.error(`SharedLinksApi waitForFilesToBeShared : catch : ${error}`);
console.error(`\tWait timeout reached waiting for files to be shared`);
Expand Down Expand Up @@ -132,7 +132,7 @@ export class SharedLinksApi {
}
};

return Utils.retryCall(sharedFile);
return await Utils.retryCall(sharedFile);
} catch (error) {
console.error(`SharedLinksApi waitForFilesToNotBeShared : catch : ${error}`);
console.error(`\tWait timeout reached waiting for files to no longer be shared`);
Expand Down
Loading