[ACS-8951] [E2E] tags and categories e2es added in ACA

[datguychen]

JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/ACS-8951

[akashrathod28]

we can replace this if with better code like below to replace unknown type checking.
if ('entry' in requestTagData) {
return (requestTagData as { entry: { id: string } }).entry.id;
}

[datguychen]

I was using 'entry' in request but sonar cloud is giving me this error:
**_Use "indexOf" or "includes" (available from ES2016) instead._**

I switched it back to using 'in' keyword and the issue occurs again. What should I do here?

[datguychen]

https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=4210&id=Alfresco_alfresco-content-app&open=AZLhr2TdcCVkb1Q-mrj7

[datguychen]

@AleksanderSklorz the sonar cloud issue is discussed here.

[AleksanderSklorz]

Hmm I see. Honestly not sure why Sonar is complaining about that. Using 'in' should be fine as well in my opinion as it looks simpler. @MichalKinas is there any reason why we can't use 'in'? Should we somehow change it for sonar?

[datguychen]

That's why I used this line of code return (createdTag as { entry: { id: string } }).entry.id;, because it treats the createdTag as a specific object with entry and id, and not as TagEntry which is somehow interpreted differently in this case.

[MichalKinas]

So in your first case you got beforeAll failed : TypeError: Cannot use 'in' operator to search for 'entry' in undefined which means that in that case createdTag[0] is undefined which means that tagsApi.createTags didn't return tags, the rest of the code should work fine I even tested that in jsconsole ->

[MichalKinas]

If you still get the error please let me know how to run this case locally I will try to debug

[datguychen]

@MichalKinas in both cases the tags are created. This is the case with createdTag[0]. I still don't understand why it creates 3 tags, but I don't think this is the issue right now. The code is up-to-date on this branch, so if you want to debug it locally, you can do it. You can message me if you encounter any issues with running the e2es.

createdTag: {
entry: { tag: 'tag-1ld4r', id: '222ce83c-e6a1-487c-ace8-3ce6a1487c98' }
}
beforeAll failed : TypeError: Cannot use 'in' operator to search for 'entry' in undefined
createdTag: {
entry: { tag: 'tag-10mri', id: '2c78ac98-e2a9-44c8-b8ac-98e2a9a4c894' }
}
beforeAll failed : TypeError: Cannot use 'in' operator to search for 'entry' in undefined
createdTag: {
entry: { tag: 'tag-137wp', id: 'bcf4dce5-93be-4955-b4dc-e593be395537' }
}
beforeAll failed : TypeError: Cannot use 'in' operator to search for 'entry' in undefined

[MichalKinas]

XD this does not return array of 3 tags, those are 3 separate calls to create tags, that's why it fails when you try to access first element, this looks like an API inconsistency since it returns an object instead of an array, I can recall we had a ticket for that somewhere? Well anyway in that case doing return (requestTagData as { entry: { id: string } }).entry.id should be fine until that gets fixed, sorry for the confusion I didn't know that API doesn't return an array

[MichalKinas]

responseCategoryId might be null if error will happen

[datguychen]

Fixed, please check if properly.

[MichalKinas]

responseTagsId may be null as well

[datguychen]

Fixed, please check if properly.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud