-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8706] split context menu to allow injecting actions #4203
Conversation
7ca1ac0
to
c14a411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please make sure to properly document this new mechanism for custom context menu so that customers can use it as well
projects/aca-content/src/lib/components/context-menu/base-context-menu.directive.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/context-menu/base-context-menu.directive.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/context-menu/base-context-menu.directive.ts
Show resolved
Hide resolved
projects/aca-content/src/lib/components/context-menu/context-menu.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/context-menu/custom-context-menu.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/context-menu/custom-context-menu.component.spec.ts
Show resolved
Hide resolved
projects/aca-shared/src/lib/directives/contextmenu/contextmenu.directive.ts
Outdated
Show resolved
Hide resolved
728c940
to
f92ef17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there are some Sonar issues to be fixed reported
projects/aca-content/src/lib/components/context-menu/custom-context-menu.component.spec.ts
Outdated
Show resolved
Hide resolved
56e3f0a
to
b049db0
Compare
b049db0
to
57857e2
Compare
Quality Gate passedIssues Measures |
JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/ACS-8706
Context menu is split into separate components: base component, default context menu used in ACA and custom context menu, allowing to inject custom actions.