Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8886] enable excluded test from ACA #4170

Merged
merged 6 commits into from
Oct 8, 2024
Merged

[ACS-8886] enable excluded test from ACA #4170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7be5468
[ACS-8886] enable excluded test
akashrathod28 Oct 8, 2024
a340e17
[ACS-8886] enable excluded test
akashrathod28 Oct 8, 2024
a1b9f7d
[ACS-8886] test fix and added ticket to resovle
akashrathod28 Oct 8, 2024
c4d5f2b
[ACS-8886] test reexcluded as valid fail
akashrathod28 Oct 8, 2024
01ce4a2
[ACS-8886] test enalbe
akashrathod28 Oct 8, 2024
828f337
[ACS-8886] test fix for admin
akashrathod28 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions e2e/playwright/copy-move-actions/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1 @@
{
"C217135": "https://hyland.atlassian.net/browse/ACS-8812",
"C291888": "https://hyland.atlassian.net/browse/ACS-8812",
"C291889": "https://hyland.atlassian.net/browse/ACS-8812",
"C217137": "https://hyland.atlassian.net/browse/ACS-8812",
"C217138": "https://hyland.atlassian.net/browse/ACS-8812",
"C217139": "https://hyland.atlassian.net/browse/ACS-8812",
"C217140": "https://hyland.atlassian.net/browse/ACS-8812",
"C217171": "https://hyland.atlassian.net/browse/ACS-8812",
"C217172": "https://hyland.atlassian.net/browse/ACS-8812",
"C217173": "https://hyland.atlassian.net/browse/ACS-8812",
"C217174": "https://hyland.atlassian.net/browse/ACS-8812"
}
{}
17 changes: 1 addition & 16 deletions e2e/playwright/delete-actions/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
{
"C217125": "https://hyland.atlassian.net/browse/ACS-8812",
"C217129": "https://hyland.atlassian.net/browse/ACS-8812",
"C217091": "https://hyland.atlassian.net/browse/ACS-8812",
"C280416": "https://hyland.atlassian.net/browse/ACS-8812",
"C290103": "https://hyland.atlassian.net/browse/ACS-8812",
"C280417": "https://hyland.atlassian.net/browse/ACS-8812",
"C217177": "https://hyland.atlassian.net/browse/ACS-8812",
"C280438": "https://hyland.atlassian.net/browse/ACS-8812",
"C290104": "https://hyland.atlassian.net/browse/ACS-8812",
"C217182": "https://hyland.atlassian.net/browse/ACS-8812",
"C217178": "https://hyland.atlassian.net/browse/ACS-8812",
"C217179": "https://hyland.atlassian.net/browse/ACS-8812",
"C217183": "https://hyland.atlassian.net/browse/ACS-8812",
"C280502": "https://hyland.atlassian.net/browse/ACS-8812",
"C217130": "https://hyland.atlassian.net/browse/ACS-8812",
"C217184": "https://hyland.atlassian.net/browse/ACS-8812"
"C280502": "https://hyland.atlassian.net/browse/ACS-8888"
}
4 changes: 1 addition & 3 deletions e2e/playwright/edit-actions/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
{
"XAT-5095": "https://hyland.atlassian.net/browse/ACS-8812"
}
{}
2 changes: 1 addition & 1 deletion e2e/playwright/folder-rules/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"XAT-897": "https://hyland.atlassian.net/browse/ACS-5503"
"XAT-897": "https://hyland.atlassian.net/browse/ACS-5503"
}
6 changes: 1 addition & 5 deletions e2e/playwright/list-views/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
{
"C213217": "https://alfresco.atlassian.net/browse/ACS-6710",
"C213245": "https://alfresco.atlassian.net/browse/ACS-6717",
"C261153": "https://alfresco.atlassian.net/browse/AAE-7517",
"C589205": "https://alfresco.atlassian.net/browse/ACS-6710",
"C261150": "https://alfresco.atlassian.net/browse/ACS-6710"
"C261153": "https://alfresco.atlassian.net/browse/AAE-7517"
}
9 changes: 3 additions & 6 deletions e2e/playwright/list-views/src/tests/trash-admin.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,18 @@
*/

import { expect } from '@playwright/test';
import { ApiClientFactory, NodesApi, Utils, getUserState, test, TrashcanApi, users } from '@alfresco/aca-playwright-shared';
import { ApiClientFactory, NodesApi, Utils, test, users } from '@alfresco/aca-playwright-shared';

test.use({ storageState: getUserState('admin') });
test.describe('Trash admin', () => {
const folderAdmin = `deleteFolder-${Utils.random()}`;
const folderAdmin = `C213217-deleteFolder-${Utils.random()}`;
let folderAdminId: string;
let adminApiActions: NodesApi;
let adminTrashcanApi: TrashcanApi;

test.beforeAll(async () => {
try {
const apiClientFactory = new ApiClientFactory();
await apiClientFactory.setUpAcaBackend('admin');
adminApiActions = await NodesApi.initialize('admin');
adminTrashcanApi = await TrashcanApi.initialize('admin');
folderAdminId = (await adminApiActions.createFolder(folderAdmin)).entry.id;
await adminApiActions.deleteNodeById(folderAdminId, false);
} catch (error) {
Expand All @@ -46,7 +43,7 @@ test.describe('Trash admin', () => {
});

test.afterAll(async () => {
await Utils.deleteNodesSitesEmptyTrashcan(adminApiActions, adminTrashcanApi, '----- afterAll failed : ');
await adminApiActions.deleteDeletedNode(folderAdminId);
});

test.beforeEach(async ({ loginPage }) => {
Expand Down
4 changes: 1 addition & 3 deletions e2e/playwright/navigation/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
{
"C280034": "https://hyland.atlassian.net/browse/ACS-8812"
}
{}
11 changes: 5 additions & 6 deletions e2e/playwright/search/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"C290019": "https://hyland.atlassian.net/browse/ACS-6928",
"C290018": "https://hyland.atlassian.net/browse/ACS-6928",
"C699046-3": "https://hyland.atlassian.net/browse/ACS-7464",
"C699498": "https://hyland.atlassian.net/browse/ACS-7682",
"C280034": "https://hyland.atlassian.net/browse/ACS-8812"
}
"C290019": "https://hyland.atlassian.net/browse/ACS-6928",
"C290018": "https://hyland.atlassian.net/browse/ACS-6928",
"C699046-3": "https://hyland.atlassian.net/browse/ACS-7464",
"C699498": "https://hyland.atlassian.net/browse/ACS-7682"
}
4 changes: 1 addition & 3 deletions e2e/playwright/upload-download-actions/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
{
"C297548": "https://hyland.atlassian.net/browse/ACS-8812"
}
{}
1 change: 1 addition & 0 deletions projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
const sortColumn = await this.getSortedColumnHeaderText();
let sortOrder = await this.getSortingOrder();
if (sortColumn !== label) {
await this.getColumnHeaderByName(label).hover();
await this.getColumnHeaderByName(label).click({ force: true });
sortOrder = await this.getSortingOrder();
}
Expand Down Expand Up @@ -200,7 +201,7 @@
* @param name of the data table element with which we want to double click
*/
async performClickFolderOrFileToOpen(name: string): Promise<void> {
await this.getCellLinkByName(name).click();

Check failure on line 204 in projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts

View workflow job for this annotation

GitHub Actions / E2E Playwright - copy-move-actions

[Copy Move Actions] › src/tests/destination-picker-dialog.e2e.ts:89:7 › Copy Move actions › [C263877] Contributor user can select the folder as destination 

  1) [Copy Move Actions] › src/tests/destination-picker-dialog.e2e.ts:89:7 › Copy Move actions › [C263877] Contributor user can select the folder as destination 
    Error: locator.click: Test timeout of 150000ms exceeded.
    Call log:
      - waiting for locator('adf-datatable .adf-cell-value span[role="link"]').filter({ hasText: 'site-1ncie' })


       at ../../../projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts:204

      202 |    */
      203 |   async performClickFolderOrFileToOpen(name: string): Promise<void> {
    > 204 |     await this.getCellLinkByName(name).click();
          |                                        ^
      205 |     await this.spinnerWaitForReload();
      206 |   }
      207 |

        at DataTableComponent.performClickFolderOrFileToOpen (/home/runner/work/alfresco-content-app/alfresco-content-app/projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts:204:40)
        at copyContentInMyLibraries (/home/runner/work/alfresco-content-app/alfresco-content-app/e2e/playwright/copy-move-actions/src/tests/destination-picker-dialog.e2e.ts:76:37)
        at /home/runner/work/alfresco-content-app/alfresco-content-app/e2e/playwright/copy-move-actions/src/tests/destination-picker-dialog.e2e.ts:92:11
await this.spinnerWaitForReload();
}

Expand Down
2 changes: 1 addition & 1 deletion ...laywright-shared/src/page-objects/components/manageRules/manage-rules-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class ManageRulesDialogComponent extends BaseComponent {
public destinationFolderButton = this.getChild('[data-automation-id="card-textitem-clickable-icon-destination-folder"]');
public ruleInBackgroundCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-asynchronous"]');
public ruleSubfoldersCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-inheritable"]');
public ruleDisableCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-disabled"]');
public ruleDisableCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-disabled"] input');
public actionsEllipsisButtons = this.getChild('[data-automation-id="rule-action-list-action-menu"]');
public actionsEllipsisDelete = this.page.locator('[data-automation-id="rule-action-list-remove-action-button"]');
public conditionsEllipsisButtons = this.getChild('[data-automation-id="condition-actions-button"]');
Expand Down
3 changes: 2 additions & 1 deletion projects/aca-playwright-shared/src/page-objects/components/sidenav.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
*/

import { SIDEBAR_LABELS } from '../../utils';
import { SIDEBAR_LABELS, timeouts } from '../../utils';
import { BaseComponent } from './base.component';
import { Locator, Page } from '@playwright/test';

Expand Down Expand Up @@ -75,6 +75,7 @@ export class SidenavComponent extends BaseComponent {
}

async isSidenavExpanded(): Promise<boolean> {
await this.page.waitForTimeout(timeouts.tiny);
return this.expandedSidenav.isVisible();
}

Expand Down
Loading