Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8779] Keep selections and question after going to the previous page #4147

Merged

Conversation

jacekpluta
Copy link
Contributor

JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/ACS-8779

@jacekpluta jacekpluta added the ai label Sep 30, 2024
@AleksanderSklorz
Copy link
Contributor

what with this case? When I click on X then files are selected but input is not pre-filled. Is that expected?

Screen.Recording.2024-09-30.at.08.56.23.mov

@AleksanderSklorz
Copy link
Contributor

When we select files and run KR on some page for example personal files and then we will go to other page from KR for example share or favourites then files are not selected but question is refilled. I guess we should hide question as well in this case as we don't select any files for this page (as previous page was personal files)?

Screen.Recording.2024-09-30.at.09.02.57.mov

@AleksanderSklorz
Copy link
Contributor

When you run query for KR and then you will open for example personal files in separated tab and then you will run refresh on KR page in first tab then you will get error page. Before that change we could refresh page and use url to open results for last question's answer.
I think the reason is that you reuse the same knowledgeRetrieval entry from localstorage which was used for that purpose. Solution can be introducing one more entry which keeps nodes (or maybe some flag instead of removing content for that entry for restoring?)

Screen.Recording.2024-09-30.at.09.09.13.mov

@AleksanderSklorz
Copy link
Contributor

If I copy url to other page and then open that other page from KR by pasting url and then go to page like personal files then no files are selected but question is prefilled. We should hide question as well:

Screen.Recording.2024-09-30.at.09.18.41.mov

@jacekpluta
Copy link
Contributor Author

what with this case? When I click on X then files are selected but input is not pre-filled. Is that expected?

Screen.Recording.2024-09-30.at.08.56.23.mov

forgot about that, should be fixed now

Screen.Recording.2024-10-02.at.23.07.45.mov

When we select files and run KR on some page for example personal files and then we will go to other page from KR for example share or favourites then files are not selected but question is refilled. I guess we should hide question as well in this case as we don't select any files for this page (as previous page was personal files)?

Screen.Recording.2024-09-30.at.09.02.57.mov

Yes, it should be working that way, no idea why it wasn't (not sure if you had my adf branch linked? I was setting there 'knowledgeRetrievalNodes' to '' and based on that hiding the input. I changed it now anyway and it should be working correctly

Screen.Recording.2024-10-03.at.00.34.08.mov

When you run query for KR and then you will open for example personal files in separated tab and then you will run refresh on KR page in first tab then you will get error page. Before that change we could refresh page and use url to open results for last question's answer. I think the reason is that you reuse the same knowledgeRetrieval entry from localstorage which was used for that purpose. Solution can be introducing one more entry which keeps nodes (or maybe some flag instead of removing content for that entry for restoring?)

Screen.Recording.2024-09-30.at.09.09.13.mov

changed the condition and no longer overriding the 'knowledgeRetrivalNode' in the local storage, looks like this fixed issue

l to other page and then open that other page from KR by pasting url and then go to page like personal files then no files are se

also should be fixed after I stopped reseting the KnowledgeRetrievalNodes in the storage

Screen.Recording.2024-10-03.at.00.37.10.mov

Screen Recording 2024-10-03 at 00.37.10.mov

@jacekpluta jacekpluta force-pushed the ACS-8779-keep-selections-after-going-to-the-previous-page branch from b6184ef to 2e2a0fb Compare October 3, 2024 07:15
@jacekpluta jacekpluta force-pushed the ACS-8779-keep-selections-after-going-to-the-previous-page branch 3 times, most recently from 0186a40 to 801c888 Compare October 3, 2024 14:08
@jacekpluta jacekpluta force-pushed the ACS-8779-keep-selections-after-going-to-the-previous-page branch from 801c888 to 70f9fae Compare October 4, 2024 07:33
Copy link

sonarqubecloud bot commented Oct 4, 2024

@jacekpluta jacekpluta merged commit 3ec6d0b into develop Oct 4, 2024
25 checks passed
@jacekpluta jacekpluta deleted the ACS-8779-keep-selections-after-going-to-the-previous-page branch October 4, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants