-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8779] Keep selections and question after going to the previous page #4147
[ACS-8779] Keep selections and question after going to the previous page #4147
Conversation
...owledge-retrieval/search-ai/search-ai-input-container/search-ai-input-container.component.ts
Outdated
Show resolved
Hide resolved
what with this case? When I click on X then files are selected but input is not pre-filled. Is that expected? Screen.Recording.2024-09-30.at.08.56.23.mov |
When we select files and run KR on some page for example personal files and then we will go to other page from KR for example share or favourites then files are not selected but question is refilled. I guess we should hide question as well in this case as we don't select any files for this page (as previous page was personal files)? Screen.Recording.2024-09-30.at.09.02.57.mov |
When you run query for KR and then you will open for example personal files in separated tab and then you will run refresh on KR page in first tab then you will get error page. Before that change we could refresh page and use url to open results for last question's answer. Screen.Recording.2024-09-30.at.09.09.13.mov |
If I copy url to other page and then open that other page from KR by pasting url and then go to page like personal files then no files are selected but question is prefilled. We should hide question as well: Screen.Recording.2024-09-30.at.09.18.41.mov |
projects/aca-shared/src/lib/services/navigation-history.service.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/services/navigation-history.service.ts
Outdated
Show resolved
Hide resolved
forgot about that, should be fixed now Screen.Recording.2024-10-02.at.23.07.45.mov
Yes, it should be working that way, no idea why it wasn't (not sure if you had my adf branch linked? I was setting there 'knowledgeRetrievalNodes' to '' and based on that hiding the input. I changed it now anyway and it should be working correctly Screen.Recording.2024-10-03.at.00.34.08.mov
changed the condition and no longer overriding the 'knowledgeRetrivalNode' in the local storage, looks like this fixed issue
also should be fixed after I stopped reseting the KnowledgeRetrievalNodes in the storage Screen.Recording.2024-10-03.at.00.37.10.movScreen Recording 2024-10-03 at 00.37.10.mov |
b6184ef
to
2e2a0fb
Compare
projects/aca-shared/src/lib/services/navigation-history.service.ts
Outdated
Show resolved
Hide resolved
...ge-retrieval/search-ai/search-ai-input-container/search-ai-input-container.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/sidenav/sidenav.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/services/navigation-history.service.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/components/document-base-page/document-base-page.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/components/document-base-page/document-base-page.spec.ts
Outdated
Show resolved
Hide resolved
0186a40
to
801c888
Compare
801c888
to
70f9fae
Compare
…he-previous-page
Quality Gate passedIssues Measures |
JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/ACS-8779