ACS-8658: fix search icon for lock files #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/lib/components/dl-custom-components/thumbnail-column/thumbnail-column.component.spec.ts
Show resolved
Hide resolved
.../src/lib/components/dl-custom-components/thumbnail-column/thumbnail-column.component.spec.ts
Outdated
Show resolved
Hide resolved
MichalKinas
reviewed
Aug 26, 2024
| <mat-icon class="adf-datatable-center-icon">{{thumbnailUrl}}</mat-icon> | ||
| </ng-container> | ||
| <ng-template #image> | ||
| <img *ngIf="!isSelected" class="adf-datatable-center-img-ie" [src]="thumbnailUrl" [alt]="tooltip" [title]="tooltip" /> |
There was a problem hiding this comment.
Do we need additional !isSelected check here? It's check on the parent ng-container
There was a problem hiding this comment.
cleaned up template, also removed the custom css classes that seem to be doing anything for this layout
DenysVuika
force-pushed
the
fix/search-lock-icon
branch
from
e9fdaf6 to
a9636b8
Compare
|
MichalKinas
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8658