-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAE-22098] Update AlfrescoApiService imports #4015
Conversation
@@ -38,7 +39,8 @@ describe('RuleActionListUiComponent', () => { | |||
|
|||
beforeEach(() => { | |||
TestBed.configureTestingModule({ | |||
imports: [CoreTestingModule] | |||
imports: [CoreTestingModule], | |||
providers: [{ provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should not be needed at all, we have this configured in the CoreTestingModule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we moved AlfrescoApiService
from core to @alfresco/adf-content-service
in ADF, therefore it is not in CoreTestingModule
anymore
@@ -63,7 +63,8 @@ describe('RuleActionUiComponent', () => { | |||
|
|||
beforeEach(() => { | |||
TestBed.configureTestingModule({ | |||
imports: [CoreTestingModule, RuleActionUiComponent] | |||
imports: [CoreTestingModule, RuleActionUiComponent], | |||
providers: [{ provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe in every place you have CoreTestingModule
this line is not needed... we can cleanup the tests even before the refactoring, so that it takes less changes in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We moved AlfrescoApiService from core to @alfresco/adf-content-service in ADF
a909c03
to
6cc37a9
Compare
1b0c2fa
to
74b9f98
Compare
a75ee59
to
e6e9023
Compare
Quality Gate passedIssues Measures |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-22098
What is the new behaviour?
AlfrescoApiService and AlfrescoApiServiceMock imports are updated.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: