Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-22098] Update AlfrescoApiService imports #4015

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

MichalKinas
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/AAE-22098

What is the new behaviour?

AlfrescoApiService and AlfrescoApiServiceMock imports are updated.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@@ -38,7 +39,8 @@ describe('RuleActionListUiComponent', () => {

beforeEach(() => {
TestBed.configureTestingModule({
imports: [CoreTestingModule]
imports: [CoreTestingModule],
providers: [{ provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should not be needed at all, we have this configured in the CoreTestingModule

Copy link
Contributor

@BSekula BSekula Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we moved AlfrescoApiService from core to @alfresco/adf-content-service in ADF, therefore it is not in CoreTestingModule anymore

@@ -63,7 +63,8 @@ describe('RuleActionUiComponent', () => {

beforeEach(() => {
TestBed.configureTestingModule({
imports: [CoreTestingModule, RuleActionUiComponent]
imports: [CoreTestingModule, RuleActionUiComponent],
providers: [{ provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in every place you have CoreTestingModule this line is not needed... we can cleanup the tests even before the refactoring, so that it takes less changes in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We moved AlfrescoApiService from core to @alfresco/adf-content-service in ADF

@BSekula BSekula force-pushed the feature/dev-mkinas-AAE-22098 branch from a909c03 to 6cc37a9 Compare August 13, 2024 08:46
@MichalKinas MichalKinas force-pushed the feature/dev-mkinas-AAE-22098 branch 2 times, most recently from 1b0c2fa to 74b9f98 Compare September 5, 2024 05:30
@BSekula BSekula force-pushed the feature/dev-mkinas-AAE-22098 branch from a75ee59 to e6e9023 Compare September 6, 2024 16:59
Copy link

sonarqubecloud bot commented Sep 6, 2024

@BSekula BSekula merged commit 796a3c7 into develop Sep 6, 2024
25 checks passed
@BSekula BSekula deleted the feature/dev-mkinas-AAE-22098 branch September 6, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants