Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-8449] Fixed alignment of close and dropdown icon in search input #3975

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[ACS-8449] Fixed alignment of close and dropdown icon in search input #3975

merged 1 commit into from
Jul 29, 2024

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Dropdown arrow and close icon alignment in search input was broken after ng15 upgrade

What is the new behaviour?
Fixed alignment of icons in search input

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://hyland.atlassian.net/browse/ACS-8449

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@swapnil-verma-gl swapnil-verma-gl merged commit bf95968 into develop Jul 29, 2024
25 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the dev-acs-8449-search-icon-alignment branch July 29, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-jaskowski g-jaskowski g-jaskowski approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swapnil-verma-gl @DenysVuika @g-jaskowski