refactor DI into inject() methods #3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
|
| private actions$ = inject(Actions); | ||
| private ngZone = inject(NgZone); | ||
| private uploadService = inject(UploadService); | ||
| rendererFactory = inject(RendererFactory2); |
There was a problem hiding this comment.
Can you verify if moving the rendererFactory inject to inside the constructor still works? According to the previous implementation, the rendererFactory instance was only available inside the constructor, and would free up its occupied memory after constructor code execution. However, with the current implementation, it would keep occupying its memory, as long as the service/component/etc is alive, even though its only really being used inside the constructor
swapnil-verma-gl
approved these changes
Jul 19, 2024
swapnil-verma-gl
pushed a commit
that referenced
this pull request
Aug 1, 2024
swapnil-verma-gl
pushed a commit
that referenced
this pull request
Aug 6, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Aug 25, 2024
dominikiwanekhyland
added a commit
that referenced
this pull request
Sep 4, 2024
dominikiwanekhyland
added a commit
that referenced
this pull request
Sep 6, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Sep 6, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Sep 9, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Sep 20, 2024
dominikiwanekhyland
added a commit
that referenced
this pull request
Sep 24, 2024
dominikiwanekhyland
added a commit
that referenced
this pull request
Sep 24, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Sep 30, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Oct 2, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Oct 4, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Oct 8, 2024
swapnil-verma-gl
pushed a commit
that referenced
this pull request
Oct 14, 2024
VitoAlbano
pushed a commit
that referenced
this pull request
Oct 15, 2024
swapnil-verma-gl
pushed a commit
that referenced
this pull request
Oct 17, 2024
MichalKinas
pushed a commit
that referenced
this pull request
Oct 23, 2024
MichalKinas
added a commit
that referenced
this pull request
Oct 23, 2024
* Updated ACA to Angular 16 * Updated Subject types to void in cases where no values was being emitted * [ACS-8375] [ACA] [General] Selecting a checkbox gives a light green color on focus (#3937) * [ACS-8376] [ACA] [[Manage Rules] Multiple UI issues in create rule dialog (#3943) * [ACS-8378] Fixed inputs having fill styling throughout ACA (#3944) * [ACS-8378] Mat form fields now have white background instead of grey * [ACS-8378] Fixed issue where the background of the boolean mode control dropdown was appearing as white when in condition groups. Labels in create rules window are now black * [ACS-8415] Sidenav labels are now grey (#3946) * [ACS-8379] Fixed issue where icons in menus were coming as black after ng16 upgrade (#3935) * refactor DI into inject() methods (#3954) * Cleanup and remove unneeded commits and changes * Fix eslint (#4032) * [REVERTABLE] - this is a quick temp fix to be able to release ACA with NG16 * [MIGRATION] - added some fix after rebase * Refactor AppEffects (#4079) * Refactor effects to use inject() (#4080) * Refactor effects to use inject() (#4081) * Rebase fixes * [ACS-8739] Fix e2e tests (#4106) * Updated ADF deps * Fixed unit passing mandatory value * Updated ADF version * Updated ADF version * [ACS-8743] [ADW] click on search button open a blank page (#4125) * Updating ADF dep * Updating ADF * Refactor injections in effects (#4137) * Upstream dependencies * Refactor SearchAiEffects * Updating ADF and rebased * Rebased and updated * Rebased and updated * Updating deps * Updating deps * Updating deps * Rebased and updated deps * Pushing package-lock.json * Moved the JWT storage injection token at app level * Updated dependencies * Fixed unit test * Improved solutio for token with no need to set it explicitly * Updating dependencies * Updated package version * Updated ADF deps * Use latest ADF --------- Co-authored-by: swapnil.verma <[email protected]> Co-authored-by: swapnil-verma-gl <[email protected]> Co-authored-by: VitoAlbano <[email protected]> Co-authored-by: Ehsan Rezaei <[email protected]> Co-authored-by: MichalKinas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: