Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-8404: Introduce App Settings service #3939

Merged
merged 5 commits into from
Jul 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
introduce app settings service
DenysVuika committed Jul 12, 2024
commit 5733daeea0403003662a63d5e64a4c203a36d057
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ export class AosEditOnlineService implements IAosEditOnlineService {
// );
const checkedOut = node.properties['cm:lockType'] === 'WRITE_LOCK' || node.properties['cm:lockType'] === 'READ_ONLY_LOCK';
const lockOwner = node.properties['cm:lockOwner'];
const differentLockOwner = lockOwner.id !== this.authenticationService.getUsername();
const differentLockOwner = lockOwner.id !== this.authenticationService.getEcmUsername();

if (checkedOut && differentLockOwner) {
this.onAlreadyLockedNotification(node.id, lockOwner.id);
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ export class AppSettingsService {
* Get the AOS (Alfresco Office Services) host URL from the app settings.
*/
get aosHost(): string {
return this.appConfig.get<string>('aosHost', '');
return this.appConfig.get<string>('aosHost');
}

/**