Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6926] Fix plugins routing #3930

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

nikita-web-ua
Copy link
Contributor

@nikita-web-ua nikita-web-ua commented Jul 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

User can open page for specific plugin by typing url even if plugin is disabled
https://hyland.atlassian.net/browse/ACS-6926

What is the new behaviour?

  • PluginEnabledGuard moved to aca-shared
  • Routing for disabled plugins restricted
  • Removed the rule that caused the “Files” section to be hidden in the navigation bar when contentService=false.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@nikita-web-ua nikita-web-ua marked this pull request as ready for review July 10, 2024 07:01
Copy link

@DenysVuika DenysVuika merged commit de74b3b into develop Jul 17, 2024
26 checks passed
@DenysVuika DenysVuika deleted the dev-mmaliarchuk/ACS-6926-fix-plugin-routing branch July 17, 2024 17:22
akashrathod28 pushed a commit that referenced this pull request Jul 24, 2024
* [ACS-6926] fix plugins routing

* [ACS-6926] add implement CanActivateChild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants