-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8113] UX bug - Checkbox selections checked state should be Hyland blue not green- edit summary #3908
Conversation
29121c6
to
0934e29
Compare
projects/aca-content/src/lib/components/favorite-libraries/favorite-libraries.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/favorite-libraries/favorite-libraries.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/favorites/favorites.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/favorites/favorites.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/libraries/libraries.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/libraries/libraries.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/recent-files/recent-files.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/recent-files/recent-files.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/shared-files/shared-files.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/shared-files/shared-files.component.html
Show resolved
Hide resolved
projects/aca-content/src/lib/components/trashcan/trashcan.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/trashcan/trashcan.component.spec.ts
Outdated
Show resolved
Hide resolved
@jacekpluta what with colors of selected row? It is different too. and here design of it in figma for AI: Background color and border are different. |
@jacekpluta some sonar issue: |
@jacekpluta checkbox in header has incorrect icon when row is selected using keyboard (spacebar) instead of mouse click. For mouse click it has minus icon what means that not all checkboxes are checked but for using keyboard it has tick icon which means that all checkboxes are checked (but only one is checked): Screen.Recording.2024-06-25.at.14.08.30.mov |
|
40df1b2
to
795f465
Compare
I have talked with Craig and we decided to change everything to color blue (row and cell borders, since they are related to accessibility) and link name / file name hover from green to blue |
@jacekpluta the code is not building |
…d blue not green- edit summary
hm, I see I need latest ADF but I can't merge upstream deps #3910 |
Quality Gate passedIssues Measures |
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
…d blue not green- edit summary (#3908)
… be Hyland blue not green- edit summary (#3908)" (#3919) * [ACS-8113] UX bug - Checkbox selections checked state should be Hyland blue not green- edit summary (#3908) * [ACS-8113] dataTable checkbox e2e fix 1 --------- Co-authored-by: jacekpluta <[email protected]> Co-authored-by: datguychen <[email protected]>
…d blue not green- edit summary
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8113
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: