Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8113] UX bug - Checkbox selections checked state should be Hyland blue not green- edit summary #3908

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

jacekpluta
Copy link
Contributor

@jacekpluta jacekpluta commented Jun 24, 2024

…d blue not green- edit summary

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8113

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@jacekpluta jacekpluta force-pushed the ACS-8113 branch 4 times, most recently from 29121c6 to 0934e29 Compare June 25, 2024 10:01
@AleksanderSklorz
Copy link
Contributor

@jacekpluta what with colors of selected row? It is different too.
Here how it looks:
image

and here design of it in figma for AI:
image

Background color and border are different.

@AleksanderSklorz
Copy link
Contributor

@jacekpluta some sonar issue:
image

@AleksanderSklorz
Copy link
Contributor

@jacekpluta checkbox in header has incorrect icon when row is selected using keyboard (spacebar) instead of mouse click. For mouse click it has minus icon what means that not all checkboxes are checked but for using keyboard it has tick icon which means that all checkboxes are checked (but only one is checked):

Screen.Recording.2024-06-25.at.14.08.30.mov

@jacekpluta
Copy link
Contributor Author

jacekpluta commented Jun 27, 2024

  1. Changed background color and border. Not sure how I didn't see this
  2. sonar cloud duplication should be close to 0% after I've fixed your remark about common function with element query
  3. fixed, are we supporting full keyboard navigation through application?

@jacekpluta jacekpluta force-pushed the ACS-8113 branch 5 times, most recently from 40df1b2 to 795f465 Compare June 27, 2024 21:02
@AleksanderSklorz
Copy link
Contributor

  1. Changed background color and border. Not sure how I didn't see this
  2. sonar cloud duplication should be close to 0% after I've fixed your remark about common function with element query
  3. fixed, are we supporting full keyboard navigation through application?
  1. I can still see green borders. In the design there is no borders I think
image 2. Thanks 3. Yes we try to support accessibility so keyboard should work as well.

@jacekpluta
Copy link
Contributor Author

I have talked with Craig and we decided to change everything to color blue (row and cell borders, since they are related to accessibility) and link name / file name hover from green to blue

@DenysVuika
Copy link
Contributor

@jacekpluta the code is not building

@jacekpluta
Copy link
Contributor Author

@jacekpluta the code is not building

hm, I see

I need latest ADF but I can't merge upstream deps #3910

Copy link

sonarqubecloud bot commented Jul 3, 2024

@jacekpluta jacekpluta merged commit 457ddb2 into develop Jul 4, 2024
26 checks passed
@jacekpluta jacekpluta deleted the ACS-8113 branch July 4, 2024 06:26
pmartinezga added a commit that referenced this pull request Jul 4, 2024
…be Hyland blue not green- edit summary (#3908)"

This reverts commit 457ddb2.
pmartinezga pushed a commit that referenced this pull request Jul 4, 2024
pmartinezga pushed a commit that referenced this pull request Jul 4, 2024
pmartinezga pushed a commit that referenced this pull request Jul 4, 2024
pmartinezga added a commit that referenced this pull request Jul 4, 2024
…be Hyland blue not green- edit summary (#3908)" (#3918)

* Revert "[ACS-8113] UX bug - Checkbox selections checked state should be Hyland blue not green- edit summary (#3908)"

This reverts commit 457ddb2.

* [ci:force]
pmartinezga pushed a commit that referenced this pull request Jul 4, 2024
pmartinezga pushed a commit that referenced this pull request Jul 4, 2024
akashrathod28 pushed a commit that referenced this pull request Jul 24, 2024
akashrathod28 pushed a commit that referenced this pull request Jul 24, 2024
…be Hyland blue not green- edit summary (#3908)" (#3918)

* Revert "[ACS-8113] UX bug - Checkbox selections checked state should be Hyland blue not green- edit summary (#3908)"

This reverts commit 457ddb2.

* [ci:force]
jacekpluta added a commit that referenced this pull request Jul 30, 2024
jacekpluta added a commit that referenced this pull request Jul 30, 2024
jacekpluta added a commit that referenced this pull request Jul 30, 2024
jacekpluta added a commit that referenced this pull request Jul 30, 2024
jacekpluta added a commit that referenced this pull request Jul 31, 2024
jacekpluta added a commit that referenced this pull request Aug 2, 2024
… be Hyland blue not green- edit summary (#3908)" (#3919)

* [ACS-8113] UX bug - Checkbox selections checked state should be Hyland blue not green- edit summary (#3908)

* [ACS-8113] dataTable checkbox e2e fix 1

---------

Co-authored-by: jacekpluta <[email protected]>
Co-authored-by: datguychen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants