[ACS-7768] unify inputs and selects across the app - revert #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AleksanderSklorz
requested review from
DenysVuika,
tomson7777,
jacekpluta,
nikita-web-ua,
swapnil-verma-gl,
MichalKinas,
g-jaskowski,
dominikiwanekhyland,
tamaragruszka and
DaryaBalvanovich
nikita-web-ua
approved these changes
May 20, 2024
MichalKinas
approved these changes
May 20, 2024
dominikiwanekhyland
approved these changes
May 20, 2024
AleksanderSklorz
deleted the
revert-3845-ACS-7768-Unify-inputs-and-selects-across-the-app
branch
swapnil-verma-gl
pushed a commit
that referenced
this pull request
Jun 6, 2024
MichalKinas
pushed a commit
that referenced
this pull request
Jul 19, 2024
MichalKinas
pushed a commit
that referenced
this pull request
Jul 19, 2024
MichalKinas
added a commit
that referenced
this pull request
Jul 22, 2024
* [ACS-6693] Angular 15 migration initial point * [ACS-6693] Angular 15 - update ADF dependencies from the ng15-start branch (#3712) * [ACS-6693] Angular 15 - adding mat core (#3715) * Stylelint fix * Migration - added stylePrepocessor for material selectors * Skip unit tests from branch release until errors are fixed * [ACS-7285] - [ACA] Angular 15 - Left sidebar + table (#3719) * [ACS-7286] Fix topbar user info issues (#3720) * [ACS-6693] Bump peerDependencies in ACA libs * [ACS-7330] edit rules dialog fixes (#3723) * [ACS-6693] Fix peer dependencies in ACA packages * [ACS-7328] Fix searchbar display (#3729) * [ACS-7631] Fix broken filters (#3735) * [ACS-7331] - Angular 15 - Edit aspects modal [ACA] * [ACS-7449] Fix broken filter labels styling (#3745) * [ACS-7351] ng15 Manage rules fixes (#3751) * [ACS-7351] ng15 manage rules fixes * [ACS-7351] cr fix * [ACS-7351] cr fix * [ACS-7370] - [ACA] Leave library dialog misses some padding (#3749) * [ACS-6693] Bump ADF version * [ACS-7372] - user profile page issues (#3757) * [ACS-7372] - [ACA] User profile page issues * [ACS-7415] - Move file dialog (#3755) * [ACS-7452] - Small screen notification banner [ACS-7418] About page (#3760) * [ACS-7452] - Small screen notification banner * [ACS-7452] - Small screen notification banner [ACS-7418] About page * [ACS-7511] Subfont for dialogs, make darker (#3765) * [ACS-7448] Fix wrong notifications colors (#3761) * [ACS-7448] Fix notifications colors, move them from adf to aca (#3771) * [ACS-7375] - Share link dialog issues (#3774) * [ACS-7517] - Notifications box (#3775) * [ACS-7373] ng15 permission tab fixes (#3762) * [ACS-7368] Fix unit tests for aca-content (#3779) * [ACS-7410] - Locked files overflow issues (#3780) * [ACS-7528] - Notification and user icons are a bit different (#3782) * [ACS-7529] - Columns visibility dropdown has broken styles (#3783) * [ACS-7537] - Share dialog (#3789) * Use latest ADF alpha * Post rebase unit test fix * Disable stylelint * Calendar button fix * [ACS-7369] ng15 migration - fix e2es (#3796) * [ACS-7369] e2e fixes * [ACS-7369] cr fix * [ACS-7331] - Angular 15 - View details sidebar (#3731) * [ACS-7542] - Upload new version dialog (#3800) * [ACS-7575] create library dialog e2e fix (#3803) * [ACS-7534] folder dialog e2e fixes (#3804) * [ACS-7574] Rules dialog edit (#3801) * [ACS-7571] Comments (#3810) * [ACS-7555] Added blue outline to focused checkboxes (#3813) * [ACS-7582] File upload dialog, fix button weight label globally (#3814) * [ACS-7531] - Search page (#3816) * [ACS-7559] Conext menus icons (#3818) * [ACS-6693] Bump ADF * Temporary lint disable * [ACS-7572] link rules dialog (#3817) * [ACS-7533] - Advanced search chips dropdowns (#3821) * [ACS-7560] Corrected background color for info snackbar (#3824) * [ACS-7558] - Toolbar and buttons (#3833) * [ACS-7573] folder rules fixes (#3836) * [ACS-7573] folder rules fixes * [ACS-7573] cr fix * [ACS-7561] - Permissions page (#3840) * [ACS-7768] unify inputs and selects across the app (#3845) * ACS-7768 Style inputs in create from template dialog * ACS-7768 Used globally configured outline appearance for inputs * ACS-7768 Style inputs for profile page * ACS-7768 Style inputs for library metadata form * ACS-7768 Style inputs for folder rules dialog * ACS-7768 Style inputs for manage rules page * ACS-7768 Set outline appearance for input, fix small issue * ACS-7768 Addressed comment * Revert "[ACS-7768] unify inputs and selects across the app (#3845)" (#3850) This reverts commit 6a5ef73. * [ACS-8043] fix js api dependencies (#3855) * [ACS-8020] Fixed inputs for create from template dialog (#3857) * [ACS-8027] Inputs for create rules (#3860) * [ACS-8052] inputs for general info for libraries (#3863) * [ACS-8052] Inputs for general info for libraries * Fix after CR * [ACS-8059] Inputs for view rules (#3865) * [ACS-8026] Fixed Task form rendering (#3864) * Updating to the latest package of 6.10 from ADF * Updating to the latest ADF/JS-API - updating dependency rule * Regenerated package lock * [ACS-8082] fix search e2e (#3876) * Using latest ADF with BC of ConfirmDialogComponent * [ACS-8099] [ACA] Testing Angular 15 - Accessibility for search text area (#3883) * [ACS-8100] [ACA] Testing Angular 15 - Accessibility for search facet and filter (#3887) * [ACS-8158] Resolved issue where long tag names were not getting word wrapped in ACA. Fixed alignment issue with tag chip cross button (#3890) * [ACS-8101] [ACA] Testing Angular 15 - Manage rule popup visual changes (#3891) * [ACS-8191] Updated codebase to use variables from mat-selectors.scss file (#3889) * [ACS-8191] Updated ACA codebase to use selectors from mat-selectors.scss file instead of hardcoded selectors * [ACS-8191] Resolved configuration issue where running unit test on aca-shared failed due to not finding adf-core styles * Update ADF dependencies (#3897) * Upgrading ADF packages * Use latest ADF * Updated packages version * Updated packages version * Updated packages version * Updated packages version * Updated packages version * Updated packages version * Updated packages version * [ACS-8253] viewer file name change position on navigation (#3914) * Updated ADF version * Use latest ADF * Package lock fix * Build fix * Restore release branch build and unit tests * E2Es fix * Fix SonarCloud issues * Stylelint fix * Stylelint fix * [ACS-8442] Remove additional checkbox label * First batch of E2E fixes * Bump ADF * Second round of E2E locators fixes * Locator fix * [ACS-8443] Fix incorrect focus style for checkboxes * E2Es locators fixes * E2E locator fixes * [ACS-6693] locator fix upload new version title * E2E locator fix * E2E locator fix * [ACS-6693] locator fix upload new version file --------- Co-authored-by: jacekpluta <[email protected]> Co-authored-by: Vito Albano <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: Mykyta Maliarchuk <[email protected]> Co-authored-by: Jacek Pluta <[email protected]> Co-authored-by: dominikiwanekhyland <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: AleksanderSklorz <[email protected]> Co-authored-by: swapnil-verma-gl <[email protected]> Co-authored-by: VitoAlbano <[email protected]> Co-authored-by: Akash Rathod <[email protected]> Co-authored-by: Ehsan Rezaei <[email protected]> Co-authored-by: [email protected] <[email protected]>
akashrathod28
added a commit
that referenced
this pull request
Jul 24, 2024
* [ACS-6693] Angular 15 migration initial point * [ACS-6693] Angular 15 - update ADF dependencies from the ng15-start branch (#3712) * [ACS-6693] Angular 15 - adding mat core (#3715) * Stylelint fix * Migration - added stylePrepocessor for material selectors * Skip unit tests from branch release until errors are fixed * [ACS-7285] - [ACA] Angular 15 - Left sidebar + table (#3719) * [ACS-7286] Fix topbar user info issues (#3720) * [ACS-6693] Bump peerDependencies in ACA libs * [ACS-7330] edit rules dialog fixes (#3723) * [ACS-6693] Fix peer dependencies in ACA packages * [ACS-7328] Fix searchbar display (#3729) * [ACS-7631] Fix broken filters (#3735) * [ACS-7331] - Angular 15 - Edit aspects modal [ACA] * [ACS-7449] Fix broken filter labels styling (#3745) * [ACS-7351] ng15 Manage rules fixes (#3751) * [ACS-7351] ng15 manage rules fixes * [ACS-7351] cr fix * [ACS-7351] cr fix * [ACS-7370] - [ACA] Leave library dialog misses some padding (#3749) * [ACS-6693] Bump ADF version * [ACS-7372] - user profile page issues (#3757) * [ACS-7372] - [ACA] User profile page issues * [ACS-7415] - Move file dialog (#3755) * [ACS-7452] - Small screen notification banner [ACS-7418] About page (#3760) * [ACS-7452] - Small screen notification banner * [ACS-7452] - Small screen notification banner [ACS-7418] About page * [ACS-7511] Subfont for dialogs, make darker (#3765) * [ACS-7448] Fix wrong notifications colors (#3761) * [ACS-7448] Fix notifications colors, move them from adf to aca (#3771) * [ACS-7375] - Share link dialog issues (#3774) * [ACS-7517] - Notifications box (#3775) * [ACS-7373] ng15 permission tab fixes (#3762) * [ACS-7368] Fix unit tests for aca-content (#3779) * [ACS-7410] - Locked files overflow issues (#3780) * [ACS-7528] - Notification and user icons are a bit different (#3782) * [ACS-7529] - Columns visibility dropdown has broken styles (#3783) * [ACS-7537] - Share dialog (#3789) * Use latest ADF alpha * Post rebase unit test fix * Disable stylelint * Calendar button fix * [ACS-7369] ng15 migration - fix e2es (#3796) * [ACS-7369] e2e fixes * [ACS-7369] cr fix * [ACS-7331] - Angular 15 - View details sidebar (#3731) * [ACS-7542] - Upload new version dialog (#3800) * [ACS-7575] create library dialog e2e fix (#3803) * [ACS-7534] folder dialog e2e fixes (#3804) * [ACS-7574] Rules dialog edit (#3801) * [ACS-7571] Comments (#3810) * [ACS-7555] Added blue outline to focused checkboxes (#3813) * [ACS-7582] File upload dialog, fix button weight label globally (#3814) * [ACS-7531] - Search page (#3816) * [ACS-7559] Conext menus icons (#3818) * [ACS-6693] Bump ADF * Temporary lint disable * [ACS-7572] link rules dialog (#3817) * [ACS-7533] - Advanced search chips dropdowns (#3821) * [ACS-7560] Corrected background color for info snackbar (#3824) * [ACS-7558] - Toolbar and buttons (#3833) * [ACS-7573] folder rules fixes (#3836) * [ACS-7573] folder rules fixes * [ACS-7573] cr fix * [ACS-7561] - Permissions page (#3840) * [ACS-7768] unify inputs and selects across the app (#3845) * ACS-7768 Style inputs in create from template dialog * ACS-7768 Used globally configured outline appearance for inputs * ACS-7768 Style inputs for profile page * ACS-7768 Style inputs for library metadata form * ACS-7768 Style inputs for folder rules dialog * ACS-7768 Style inputs for manage rules page * ACS-7768 Set outline appearance for input, fix small issue * ACS-7768 Addressed comment * Revert "[ACS-7768] unify inputs and selects across the app (#3845)" (#3850) This reverts commit 6a5ef73. * [ACS-8043] fix js api dependencies (#3855) * [ACS-8020] Fixed inputs for create from template dialog (#3857) * [ACS-8027] Inputs for create rules (#3860) * [ACS-8052] inputs for general info for libraries (#3863) * [ACS-8052] Inputs for general info for libraries * Fix after CR * [ACS-8059] Inputs for view rules (#3865) * [ACS-8026] Fixed Task form rendering (#3864) * Updating to the latest package of 6.10 from ADF * Updating to the latest ADF/JS-API - updating dependency rule * Regenerated package lock * [ACS-8082] fix search e2e (#3876) * Using latest ADF with BC of ConfirmDialogComponent * [ACS-8099] [ACA] Testing Angular 15 - Accessibility for search text area (#3883) * [ACS-8100] [ACA] Testing Angular 15 - Accessibility for search facet and filter (#3887) * [ACS-8158] Resolved issue where long tag names were not getting word wrapped in ACA. Fixed alignment issue with tag chip cross button (#3890) * [ACS-8101] [ACA] Testing Angular 15 - Manage rule popup visual changes (#3891) * [ACS-8191] Updated codebase to use variables from mat-selectors.scss file (#3889) * [ACS-8191] Updated ACA codebase to use selectors from mat-selectors.scss file instead of hardcoded selectors * [ACS-8191] Resolved configuration issue where running unit test on aca-shared failed due to not finding adf-core styles * Update ADF dependencies (#3897) * Upgrading ADF packages * Use latest ADF * Updated packages version * Updated packages version * Updated packages version * Updated packages version * Updated packages version * Updated packages version * Updated packages version * [ACS-8253] viewer file name change position on navigation (#3914) * Updated ADF version * Use latest ADF * Package lock fix * Build fix * Restore release branch build and unit tests * E2Es fix * Fix SonarCloud issues * Stylelint fix * Stylelint fix * [ACS-8442] Remove additional checkbox label * First batch of E2E fixes * Bump ADF * Second round of E2E locators fixes * Locator fix * [ACS-8443] Fix incorrect focus style for checkboxes * E2Es locators fixes * E2E locator fixes * [ACS-6693] locator fix upload new version title * E2E locator fix * E2E locator fix * [ACS-6693] locator fix upload new version file --------- Co-authored-by: jacekpluta <[email protected]> Co-authored-by: Vito Albano <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: Mykyta Maliarchuk <[email protected]> Co-authored-by: Jacek Pluta <[email protected]> Co-authored-by: dominikiwanekhyland <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: AleksanderSklorz <[email protected]> Co-authored-by: swapnil-verma-gl <[email protected]> Co-authored-by: VitoAlbano <[email protected]> Co-authored-by: Akash Rathod <[email protected]> Co-authored-by: Ehsan Rezaei <[email protected]> Co-authored-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3845