Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6543] switch from aws to gha cache #3582

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jan 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • switch to GHA cache instead of AWS S3
  • remove the need for the following variables:
    • AWS_ACCESS_KEY_ID
    • AWS_SECRET_ACCESS_KEY
    • AWS_REGION
    • S3_DBP_FOLDER
    • S3_DBP_ROOT_FOLDER
    • CONTENT_CE_DIST_PATH
    • NPM_REGISTRY_ADDRESS
  • remove codeowners to reduce noise (outdated configuration)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-6543

@DenysVuika DenysVuika changed the title [ACS-6543] switch to gha cache [ACS-6543] switch from aws to gha cache Jan 3, 2024
@DenysVuika DenysVuika marked this pull request as ready for review January 3, 2024 19:11
@DenysVuika DenysVuika requested a review from eromano as a code owner January 3, 2024 19:11
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dominikiwanekhyland dominikiwanekhyland self-requested a review January 4, 2024 06:34
@DenysVuika DenysVuika merged commit 33c3d6f into develop Jan 4, 2024
26 checks passed
@DenysVuika DenysVuika deleted the gha-build-cache branch January 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants