[ACS-6252] support disabling the tags and categories feature in the applications #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderSklorz
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
dominikiwanekhyland
AleksanderSklorz
requested review from
DenysVuika and
eromano
as code owners
...s/aca-content/folder-rules/src/rule-details/conditions/rule-simple-condition.ui-component.ts
Outdated
Show resolved
Hide resolved
MichalKinas
reviewed
Nov 23, 2023
| @@ -82,6 +88,9 @@ export class RuleActionUiComponent implements ControlValueAccessor, OnInit, OnCh | |||
| this._parameterConstraints = value.map((obj) => ({ ...obj, constraints: this.parseConstraintsToSelectOptions(obj.constraints) })); | |||
| } | |||
|
|
|||
| private readonly tagsRelatedPropertiesAndAspects = ['cm:tagscope', 'cm:tagScopeCache', 'cm:taggable']; | |||
| private readonly categoriesRelatedPropertiesAndAspects = ['cm:categories', 'cm:generalclassifiable']; | |||
There was a problem hiding this comment.
Does cm:generalclassifiable aspect affect only categories? Can we verify it with someone from BE?
There was a problem hiding this comment.
sure I will try to ask somebody from BE
| store = TestBed.inject(Store); | ||
| }); | ||
|
|
||
| it('show pass empty when store is in initial state', () => { |
There was a problem hiding this comment.
I think description should start from should
MichalKinas
approved these changes
Nov 23, 2023
swapnil-verma-gl
approved these changes
Nov 23, 2023
nikita-web-ua
approved these changes
Nov 23, 2023
… hide tags column from personal files
…rties and aspects in folder rules when that feature is disabled
…ng in app.config.json
…rected unit test title
AleksanderSklorz
force-pushed
the
ACS-6252-Support-disabling-the-Tags-and-Categories-feature-in-the-applications
branch
from
2e8eb24 to
cd02a0d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AleksanderSklorz
deleted the
ACS-6252-Support-disabling-the-Tags-and-Categories-feature-in-the-applications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6252
What is the new behaviour?
Allowing to hide things related with tags and categories features.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
ADF PR: Alfresco/alfresco-ng2-components#9106
alfresco-applications PR: https://github.com/Alfresco/alfresco-applications/pull/439