[ACS-6278] - stop showing 'edit aspects' and 'manage rules' when node is a smart folder #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
dominikiwanekhyland
requested review from
DenysVuika and
eromano
as code owners
AleksanderSklorz
approved these changes
Nov 8, 2023
MichalKinas
reviewed
Nov 8, 2023
| @@ -624,3 +626,19 @@ export function canOpenWithOffice(context: AcaRuleContext): boolean { | |||
|
|
|||
| return context.permissions.check(file, ['update']); | |||
| } | |||
|
|
|||
| function isSmartFolder(context: RuleContext): boolean { | |||
There was a problem hiding this comment.
We should use AcaRuleContext otherwise this rule won't be reusable in ADW as far as I remember
There was a problem hiding this comment.
isSmartFolder has parameter with RuleContext, because canEditAspects and canManagePermissions also have that. In ADW there is imported for example:
export const canEditAspects = (context: RuleContext)
so I think it would be fine if I just leave it like that?
dominikiwanekhyland
force-pushed
the
ACS-6278-permissions-manager-should-not-be-showed-for-smart-folder
branch
from
5ad5fe3 to
6c55b94
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MichalKinas
approved these changes
Nov 9, 2023
dominikiwanekhyland
deleted the
ACS-6278-permissions-manager-should-not-be-showed-for-smart-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
When node is a smart folder and user right clicks on it, there are 'manage rules' and 'edit aspects' visible.
What is the new behaviour?
Those options are not available for smart folders.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: