Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5678] delete protractor tests create folder from template #3507

Merged
merged 3 commits into from
Nov 6, 2023
Merged

[ACS-5678] delete protractor tests create folder from template #3507

merged 3 commits into from
Nov 6, 2023

Conversation

azakrzewski-hy
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Create folder from template Protractor tests are excluded but may impact Playwright tests

What is the new behaviour?
Create folder from template Protractor tests are deleted

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DenysVuika DenysVuika merged commit ed4d2cf into develop Nov 6, 2023
29 checks passed
@DenysVuika DenysVuika deleted the ACS-5678-delete-protractor-tests-create-folder-from-template branch November 6, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalKinas MichalKinas MichalKinas approved these changes

@akashrathod28 akashrathod28 akashrathod28 approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano Awaiting requested review from eromano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azakrzewski-hy @DenysVuika @akashrathod28 @MichalKinas